third_party/crashpad/crashpad/util/net/http_transport_win.cc - Issue 2236493004: Update Crashpad to 56b14bceefcec03fc11b3222c435522922f65640

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/util/net/http_transport_win.cc

Issue 2236493004: Update Crashpad to 56b14bceefcec03fc11b3222c435522922f65640 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc ('K') | « third_party/crashpad/crashpad/util/mach/exception_types.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/util/net/http_transport_win.cc

diff --git a/third_party/crashpad/crashpad/util/net/http_transport_win.cc b/third_party/crashpad/crashpad/util/net/http_transport_win.cc

index 6ee8e5ff34f38710791653f90c9ea7650cf316dc..58ecc4786b249d2894094a058d6aedfebaf4a995 100644

--- a/third_party/crashpad/crashpad/util/net/http_transport_win.cc

+++ b/third_party/crashpad/crashpad/util/net/http_transport_win.cc

@@ -179,8 +179,12 @@ bool HTTPTransportWin::ExecuteSynchronously(std::string* response_body) {

uint8_t buffer[kBufferSize];

FileOperationResult bytes_to_write =

body_stream()->GetBytesBuffer(buffer, sizeof(buffer));

- if (bytes_to_write == 0)

+ if (bytes_to_write == 0) {

break;

+ } else if (bytes_to_write < 0) {

+ LOG(ERROR) << "GetBytesBuffer failed";

+ return false;

+ }

post_data.insert(post_data.end(), buffer, buffer + bytes_to_write);

}