third_party/crashpad/crashpad/test/paths_mac.cc - Issue 2236493004: Update Crashpad to 56b14bceefcec03fc11b3222c435522922f65640

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/test/paths_mac.cc

Issue 2236493004: Update Crashpad to 56b14bceefcec03fc11b3222c435522922f65640 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/crashpad/crashpad/snapshot/mac/mach_o_image_annotations_reader_test.cc ('K') | « third_party/crashpad/crashpad/test/multiprocess_posix.cc ('k') | third_party/crashpad/crashpad/third_party/getopt/README.crashpad » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/test/paths_mac.cc

diff --git a/third_party/crashpad/crashpad/test/paths_mac.cc b/third_party/crashpad/crashpad/test/paths_mac.cc

index ce6c5f3bacc9292abb2b3b87729b11b99b5cd7be..f3dca57a96bf46d5da5faf2f8bdc0c027cf6b408 100644

--- a/third_party/crashpad/crashpad/test/paths_mac.cc

+++ b/third_party/crashpad/crashpad/test/paths_mac.cc

@@ -27,7 +27,7 @@ base::FilePath Paths::Executable() {

uint32_t executable_length = 0;

_NSGetExecutablePath(nullptr, &executable_length);

DCHECK_GT(executable_length, 1u);

- std::string executable_path(executable_length, std::string::value_type());

+ std::string executable_path(executable_length - 1, std::string::value_type());

int rv = _NSGetExecutablePath(&executable_path[0], &executable_length);

DCHECK_EQ(rv, 0);