Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: third_party/crashpad/crashpad/snapshot/mac/process_reader_test.cc

Issue 2236493004: Update Crashpad to 56b14bceefcec03fc11b3222c435522922f65640 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/snapshot/mac/process_reader_test.cc
diff --git a/third_party/crashpad/crashpad/snapshot/mac/process_reader_test.cc b/third_party/crashpad/crashpad/snapshot/mac/process_reader_test.cc
index 2cbf8ea09e160df6ab19d02a663ad9367547c4e0..ed717b65a451a77fb08f6025737a29aa8fc9ee1b 100644
--- a/third_party/crashpad/crashpad/snapshot/mac/process_reader_test.cc
+++ b/third_party/crashpad/crashpad/snapshot/mac/process_reader_test.cc
@@ -56,6 +56,8 @@ namespace crashpad {
namespace test {
namespace {
+const char kDyldPath[] = "/usr/lib/dyld";
+
TEST(ProcessReader, SelfBasic) {
ProcessReader process_reader;
ASSERT_TRUE(process_reader.Initialize(mach_task_self()));
@@ -690,7 +692,7 @@ TEST(ProcessReader, SelfModules) {
EXPECT_EQ(ExpectCLKernels(), found_cl_kernels);
size_t index = modules.size() - 1;
- EXPECT_EQ("/usr/lib/dyld", modules[index].name);
+ EXPECT_EQ(kDyldPath, modules[index].name);
// dyld didn’t load itself either, so it couldn’t record its timestamp, and it
// is also reported as 0.
@@ -800,7 +802,7 @@ class ProcessReaderModulesChild final : public MachMultiprocess {
dyld_image_address =
reinterpret_cast<mach_vm_address_t>(_dyld_get_image_header(index));
} else {
- dyld_image_name = "/usr/lib/dyld";
+ dyld_image_name = kDyldPath;
dyld_image_address = reinterpret_cast<mach_vm_address_t>(
dyld_image_infos->dyldImageLoadAddress);
}

Powered by Google App Engine
This is Rietveld 408576698