Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2234193002: DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars. (Closed)

Created:
4 years, 4 months ago by pfeldman
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars. BUG=634145 Committed: https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d Cr-Commit-Position: refs/heads/master@{#411269}

Patch Set 1 #

Total comments: 10

Patch Set 2 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -187 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/debugger/fetch-breakpoints.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints-after-suspension.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints-script-first-stmt.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/event-listener-breakpoints-xhr.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/xhr-breakpoints.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html View 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-skip-break-program.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-step-from-framework.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/skip-pauses-until-reload.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/step-through-event-listeners.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/break-on-empty-event-listener.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js View 1 3 chunks +21 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 1 2 chunks +15 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js View 4 chunks +15 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js View 1 5 chunks +15 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js View 1 5 chunks +32 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js View 5 chunks +15 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 10 chunks +6 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js View 1 4 chunks +28 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 1 3 chunks +26 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/View.js View 1 5 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
pfeldman
4 years, 4 months ago (2016-08-11 00:03:38 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2234193002/diff/1/third_party/WebKit/Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js File third_party/WebKit/Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js (right): https://codereview.chromium.org/2234193002/diff/1/third_party/WebKit/Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js#newcode50 third_party/WebKit/Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js:50: WebInspector.context.addFlavorChangeListener(WebInspector.Target, this.clearBreakpointHighlight, this); Let's highlight here as well. ...
4 years, 4 months ago (2016-08-11 01:42:16 UTC) #3
pfeldman
all done
4 years, 4 months ago (2016-08-11 01:56:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234193002/20001
4 years, 4 months ago (2016-08-11 01:59:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 05:00:09 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a2ba1b7df9fc7c12af50a18cafb6f18a75871f7d Cr-Commit-Position: refs/heads/master@{#411269}
4 years, 4 months ago (2016-08-11 05:08:17 UTC) #10
wOxxOm
It made Call Stack panel expand unconditionally on every pause, which is a huge UX ...
4 years, 1 month ago (2016-11-01 23:53:32 UTC) #11
alec.perkey
4 years ago (2016-11-30 07:21:33 UTC) #12
Message was sent while issue was closed. 
On 2016/11/01 23:53:32, wOxxOm wrote:
> It made Call Stack panel expand unconditionally on every pause, which is a
huge
> UX problem in case of a long list, see https://crbug.com/661293

Solution #7 in duplicate ticket seems optimal UX and simple (reorder call stack
and scope panels w/ scope on top) 
see https://crbug.com/656109

Powered by Google App Engine
This is Rietveld 408576698