Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html

Issue 2234193002: DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html b/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html
index dfd8bf9ce7b81ce9ad109aa6b45ceb4fef3f51ff..6a2d34935cd77a610f5dce3c533eb90600617d69 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html
@@ -14,7 +14,7 @@ function test()
InspectorTest.waitForServiceWorker(step1);
InspectorTest.registerServiceWorker(scriptURL, scope);
- var objectEventListenersPane = WebInspector.panels.sources.sidebarPanes.objectEventListeners;
+ var objectEventListenersPane = self.runtime.sharedInstance(WebInspector.ObjectEventListenersSidebarPane);
function isDedicatedWorker()
{
@@ -33,7 +33,7 @@ function test()
InspectorTest.selectThread(executionContext.target());
InspectorTest.addResult("Context is dedicated worker: " + isDedicatedWorker());
InspectorTest.addResult("Dumping listeners");
- objectEventListenersPane.revealView().then(() => {
+ WebInspector.viewManager.showView("sources.globalListeners").then(() => {
objectEventListenersPane.update();
InspectorTest.expandAndDumpEventListeners(objectEventListenersPane._eventListenersView, step3);
});

Powered by Google App Engine
This is Rietveld 408576698