Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html

Issue 2234193002: DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html
index 2727749c92510698fc42469580f7030cf7e72a04..d43006369872a93965c5460f3835164a473bb0cd 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-frameworks/frameworks-dom-xhr-event-breakpoints.html
@@ -93,7 +93,7 @@ function test()
function testXHRBreakpoint(next)
{
- var pane = WebInspector.panels.sources.sidebarPanes.xhrBreakpoints;
+ var pane = self.runtime.sharedInstance(WebInspector.XHRBreakpointsSidebarPane);
pane._setBreakpoint("foo", true);
InspectorTest.evaluateInPageWithTimeout("sendXHR('/foo?a=b')");
InspectorTest.waitUntilPausedAndDumpStackAndResume(next);
@@ -101,7 +101,7 @@ function test()
function testEventListenerBreakpoint(next)
{
- var pane = WebInspector.panels.sources.sidebarPanes.eventListenerBreakpoints;
+ var pane = self.runtime.sharedInstance(WebInspector.EventListenerBreakpointsSidebarPane);
pane._setBreakpoint("listener:click");
InspectorTest.evaluateInPageWithTimeout("addListenerAndClick(false)");
InspectorTest.waitUntilPausedAndPerformSteppingActions([
@@ -112,7 +112,7 @@ function test()
function testSteppingThroughEventListenerBreakpoint(next)
{
- var pane = WebInspector.panels.sources.sidebarPanes.eventListenerBreakpoints;
+ var pane = self.runtime.sharedInstance(WebInspector.EventListenerBreakpointsSidebarPane);
pane._setBreakpoint("listener:click");
InspectorTest.evaluateInPageWithTimeout("addListenerAndClick(true)");
InspectorTest.waitUntilPausedAndPerformSteppingActions([
@@ -127,7 +127,7 @@ function test()
function testSteppingOutOnEventListenerBreakpoint(next)
{
- var pane = WebInspector.panels.sources.sidebarPanes.eventListenerBreakpoints;
+ var pane = self.runtime.sharedInstance(WebInspector.EventListenerBreakpointsSidebarPane);
pane._setBreakpoint("listener:click");
InspectorTest.evaluateInPageWithTimeout("addListenerAndClick(true)");
InspectorTest.waitUntilPausedAndPerformSteppingActions([
@@ -140,7 +140,7 @@ function test()
function testSteppingOutOnEventListenerBreakpointAllBlackboxed(next)
{
- var pane = WebInspector.panels.sources.sidebarPanes.eventListenerBreakpoints;
+ var pane = self.runtime.sharedInstance(WebInspector.EventListenerBreakpointsSidebarPane);
pane._setBreakpoint("listener:click");
InspectorTest.evaluateInPageWithTimeout("addFewBlackboxedListenersAndClick(false)");
InspectorTest.waitUntilPausedAndPerformSteppingActions([
@@ -151,7 +151,7 @@ function test()
function testSteppingOutOnEventListenerBreakpointAllBlackboxedButOne(next)
{
- var pane = WebInspector.panels.sources.sidebarPanes.eventListenerBreakpoints;
+ var pane = self.runtime.sharedInstance(WebInspector.EventListenerBreakpointsSidebarPane);
pane._setBreakpoint("listener:click");
InspectorTest.evaluateInPageWithTimeout("addFewBlackboxedListenersAndClick(true)");
InspectorTest.waitUntilPausedAndPerformSteppingActions([
@@ -164,8 +164,8 @@ function test()
function tearDown(next)
{
- WebInspector.panels.sources.sidebarPanes.xhrBreakpoints._removeBreakpoint("foo");
- WebInspector.panels.sources.sidebarPanes.eventListenerBreakpoints._removeBreakpoint("listener:click");
+ self.runtime.sharedInstance(WebInspector.XHRBreakpointsSidebarPane)._removeBreakpoint("foo");
+ self.runtime.sharedInstance(WebInspector.EventListenerBreakpointsSidebarPane)._removeBreakpoint("listener:click");
next();
}
]);

Powered by Google App Engine
This is Rietveld 408576698