Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

Issue 2234193002: DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
index 35d0bbf68a1888782ac789bcd020829a19effb33..6c38cbe871bede19d7d427d9a5af397d77184b25 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
@@ -34,7 +34,7 @@
*/
WebInspector.DOMBreakpointsSidebarPane = function()
{
- WebInspector.BreakpointsSidebarPaneBase.call(this, WebInspector.UIString("DOM Breakpoints"));
+ WebInspector.BreakpointsSidebarPaneBase.call(this);
this._domBreakpointsSetting = WebInspector.settings.createLocalSetting("domBreakpoints", []);
this.listElement.classList.add("dom-breakpoints-list");
@@ -320,25 +320,29 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
this._saveBreakpoints();
},
- highlightBreakpoint: function(auxData)
+ /**
+ * @override
+ * @param {?WebInspector.DebuggerPausedDetails} details
+ */
+ highlightDetails: function(details)
{
+ if (!details || details.reason !== WebInspector.DebuggerModel.BreakReason.DOM) {
+ if (this._highlightedElement) {
+ this._highlightedElement.classList.remove("breakpoint-hit");
+ delete this._highlightedElement;
+ }
+ return;
+ }
+ var auxData = details.auxData;
var breakpointId = this._createBreakpointId(auxData.nodeId, auxData.type);
var element = this._breakpointElements[breakpointId];
if (!element)
return;
- this.revealView();
+ WebInspector.viewManager.revealViewWithWidget(this);
element.classList.add("breakpoint-hit");
this._highlightedElement = element;
},
- clearBreakpointHighlight: function()
- {
- if (this._highlightedElement) {
- this._highlightedElement.classList.remove("breakpoint-hit");
- delete this._highlightedElement;
- }
- },
-
/**
* @param {number} nodeId
* @param {!DOMDebuggerAgent.DOMBreakpointType} type

Powered by Google App Engine
This is Rietveld 408576698