third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js - Issue 2234193002: DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

Issue 2234193002: DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

index bbcdf0febb10ae51e308f31b0d1160ad4968ba2f..75d087994619d9829f2aace70eec5b6111d15c67 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

@@ -53,8 +53,8 @@ WebInspector.WatchExpressionsSidebarPane = function()

this._bodyElement.addEventListener("contextmenu", this._contextMenu.bind(this), false);

this._expandController = new WebInspector.ObjectPropertiesSectionExpandController();

- WebInspector.context.addFlavorChangeListener(WebInspector.ExecutionContext, this.refreshExpressions, this);

+ WebInspector.context.addFlavorChangeListener(WebInspector.ExecutionContext, this._refreshExpressions, this);

+ WebInspector.context.addFlavorChangeListener(WebInspector.DebuggerModel.CallFrame, this._refreshExpressions, this);

this._linkifier = new WebInspector.Linkifier();

}

@@ -64,7 +64,7 @@ WebInspector.WatchExpressionsSidebarPane.prototype = {

this._refreshExpressionsIfNeeded();

- refreshExpressions: function()

+ _refreshExpressions: function()

{

this._requiresUpdate = true;

this._refreshExpressionsIfNeeded();

@@ -128,7 +128,7 @@ WebInspector.WatchExpressionsSidebarPane.prototype = {

_refreshButtonClicked: function(event)

{

event.consume();

- this.refreshExpressions();

+ this._refreshExpressions();

_rebuildWatchExpressions: function()