third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js - Issue 2234193002: DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

Issue 2234193002: DevTools: migrate some of the sources panel sidebar panes to view management, allow view toolbars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

index 858a67ea3de18b903360fc120a44a17f7f2bdbba..bf8f41881ef1ca94ee528af5ee9c8c17861a519f 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

@@ -33,16 +33,15 @@ WebInspector.ScopeChainSidebarPane = function()

WebInspector.SimpleView.call(this, WebInspector.UIString("Scope"));

this._expandController = new WebInspector.ObjectPropertiesSectionExpandController();

this._linkifier = new WebInspector.Linkifier();

+ WebInspector.context.addFlavorChangeListener(WebInspector.DebuggerModel.CallFrame, this._update, this);

}

WebInspector.ScopeChainSidebarPane._pathSymbol = Symbol("path");

WebInspector.ScopeChainSidebarPane.prototype = {

- /**

- * @param {?WebInspector.DebuggerModel.CallFrame} callFrame

- */

- update: function(callFrame)

+ _update: function()

{

+ var callFrame = WebInspector.context.flavor(WebInspector.DebuggerModel.CallFrame);

this._linkifier.reset();

WebInspector.SourceMapNamesResolver.resolveThisObject(callFrame)

.then(this._innerUpdate.bind(this, callFrame));