Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2233333002: Made StylePropertySet::setProperty take a const CSSValue& instead of ptr (Closed)

Created:
4 years, 4 months ago by sashab
Modified:
4 years, 4 months ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Eric Willigers, rjwright, rwlbuis, shans, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made StylePropertySet::setProperty take a const CSSValue& instead of ptr Made StylePropertySet::setProperty take a const CSSValue& instead of a const CSSValue*. This is more semantically correct and safe since StylePropertySets cannot store nullptrs, and is also an attempt to fix a strange performance issue caused from introducing const CSSValue*s. BUG=526586, 618674 Committed: https://crrev.com/e6a32634cfd6854cd84dc18b0572e922e4ae6cbc Cr-Commit-Position: refs/heads/master@{#411504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -31 lines) Patch
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLHRElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.cpp View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sashab
4 years, 4 months ago (2016-08-11 08:30:10 UTC) #2
rune
lgtm if it passes compile+test
4 years, 4 months ago (2016-08-11 09:13:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2233333002/1
4 years, 4 months ago (2016-08-11 23:41:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 01:17:31 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 01:19:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6a32634cfd6854cd84dc18b0572e922e4ae6cbc
Cr-Commit-Position: refs/heads/master@{#411504}

Powered by Google App Engine
This is Rietveld 408576698