third_party/WebKit/Source/core/html/HTMLHRElement.cpp - Issue 2233333002: Made StylePropertySet::setProperty take a const CSSValue& instead of ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLHRElement.cpp

Issue 2233333002: Made StylePropertySet::setProperty take a const CSSValue& instead of ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLTableElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLHRElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLHRElement.cpp b/third_party/WebKit/Source/core/html/HTMLHRElement.cpp

index 6a67cc7c0e9ffd73d5d71299d3f51b4a96d9a547..00ce4c7efaade002de2533c59497ddfa0dfdb51c 100644

--- a/third_party/WebKit/Source/core/html/HTMLHRElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLHRElement.cpp

@@ -76,7 +76,7 @@ void HTMLHRElement::collectStyleForPresentationAttribute(const QualifiedName& na

if (!hasAttribute(colorAttr)) {

addPropertyToPresentationAttributeStyle(style, CSSPropertyBorderStyle, CSSValueSolid);

- CSSColorValue* darkGrayValue = CSSColorValue::create(Color::darkGray);

+ const CSSColorValue& darkGrayValue = *CSSColorValue::create(Color::darkGray);

style->setProperty(CSSPropertyBorderColor, darkGrayValue);

style->setProperty(CSSPropertyBackgroundColor, darkGrayValue);

}

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLTableElement.cpp » ('j') | no next file with comments »