third_party/WebKit/Source/core/html/HTMLElement.cpp - Issue 2233333002: Made StylePropertySet::setProperty take a const CSSValue& instead of ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLElement.cpp

Issue 2233333002: Made StylePropertySet::setProperty take a const CSSValue& instead of ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('k') | third_party/WebKit/Source/core/html/HTMLHRElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLElement.cpp b/third_party/WebKit/Source/core/html/HTMLElement.cpp

index 77fcde2979b8d922226863f3529f7a3e697db8d9..b2161ea98f5e1fe796d83153530780381ecf1ee3 100644

--- a/third_party/WebKit/Source/core/html/HTMLElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLElement.cpp

@@ -996,7 +996,7 @@ void HTMLElement::addHTMLColorToStyle(MutableStylePropertySet* style, CSSPropert

if (!parseColorWithLegacyRules(attributeValue, parsedColor))

return;

- style->setProperty(propertyID, CSSColorValue::create(parsedColor.rgb()));

+ style->setProperty(propertyID, *CSSColorValue::create(parsedColor.rgb()));

}

bool HTMLElement::isInteractiveContent() const