Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: third_party/WebKit/Source/core/html/HTMLTableElement.cpp

Issue 2233333002: Made StylePropertySet::setProperty take a const CSSValue& instead of ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLHRElement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLTableElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
index 78ff4580500fe92862115177a635a7fa3c9122f0..dbb9aae758f94fbeb4d4dca48f12513a02c001cc 100644
--- a/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
@@ -457,24 +457,24 @@ StylePropertySet* HTMLTableElement::createSharedCellStyle()
style->setProperty(CSSPropertyBorderRightWidth, CSSValueThin);
style->setProperty(CSSPropertyBorderLeftStyle, CSSValueSolid);
style->setProperty(CSSPropertyBorderRightStyle, CSSValueSolid);
- style->setProperty(CSSPropertyBorderColor, CSSInheritedValue::create());
+ style->setProperty(CSSPropertyBorderColor, *CSSInheritedValue::create());
break;
case SolidBordersRowsOnly:
style->setProperty(CSSPropertyBorderTopWidth, CSSValueThin);
style->setProperty(CSSPropertyBorderBottomWidth, CSSValueThin);
style->setProperty(CSSPropertyBorderTopStyle, CSSValueSolid);
style->setProperty(CSSPropertyBorderBottomStyle, CSSValueSolid);
- style->setProperty(CSSPropertyBorderColor, CSSInheritedValue::create());
+ style->setProperty(CSSPropertyBorderColor, *CSSInheritedValue::create());
break;
case SolidBorders:
- style->setProperty(CSSPropertyBorderWidth, CSSPrimitiveValue::create(1, CSSPrimitiveValue::UnitType::Pixels));
- style->setProperty(CSSPropertyBorderStyle, CSSPrimitiveValue::createIdentifier(CSSValueSolid));
- style->setProperty(CSSPropertyBorderColor, CSSInheritedValue::create());
+ style->setProperty(CSSPropertyBorderWidth, *CSSPrimitiveValue::create(1, CSSPrimitiveValue::UnitType::Pixels));
+ style->setProperty(CSSPropertyBorderStyle, *CSSPrimitiveValue::createIdentifier(CSSValueSolid));
+ style->setProperty(CSSPropertyBorderColor, *CSSInheritedValue::create());
break;
case InsetBorders:
- style->setProperty(CSSPropertyBorderWidth, CSSPrimitiveValue::create(1, CSSPrimitiveValue::UnitType::Pixels));
- style->setProperty(CSSPropertyBorderStyle, CSSPrimitiveValue::createIdentifier(CSSValueInset));
- style->setProperty(CSSPropertyBorderColor, CSSInheritedValue::create());
+ style->setProperty(CSSPropertyBorderWidth, *CSSPrimitiveValue::create(1, CSSPrimitiveValue::UnitType::Pixels));
+ style->setProperty(CSSPropertyBorderStyle, *CSSPrimitiveValue::createIdentifier(CSSValueInset));
+ style->setProperty(CSSPropertyBorderColor, *CSSInheritedValue::create());
break;
case NoBorders:
// If 'rules=none' then allow any borders set at cell level to take effect.
@@ -482,7 +482,7 @@ StylePropertySet* HTMLTableElement::createSharedCellStyle()
}
if (m_padding)
- style->setProperty(CSSPropertyPadding, CSSPrimitiveValue::create(m_padding, CSSPrimitiveValue::UnitType::Pixels));
+ style->setProperty(CSSPropertyPadding, *CSSPrimitiveValue::create(m_padding, CSSPrimitiveValue::UnitType::Pixels));
return style;
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLHRElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698