Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2233333002: Made StylePropertySet::setProperty take a const CSSValue& instead of ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Element.cpp
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp
index 66d497b9e899b3ef298489a85204ee7e08dec7f3..881fc63a18c90cfccaaa2c020bb0e1a33395b7f5 100644
--- a/third_party/WebKit/Source/core/dom/Element.cpp
+++ b/third_party/WebKit/Source/core/dom/Element.cpp
@@ -3637,7 +3637,7 @@ void Element::setInlineStyleProperty(CSSPropertyID propertyID, double value, CSS
void Element::setInlineStyleProperty(CSSPropertyID propertyID, const CSSValue* value, bool important)
{
DCHECK(isStyledElement());
- ensureMutableInlineStyle().setProperty(propertyID, value, important);
+ ensureMutableInlineStyle().setProperty(propertyID, *value, important);
inlineStyleChanged();
}
@@ -3682,13 +3682,13 @@ void Element::updatePresentationAttributeStyle()
void Element::addPropertyToPresentationAttributeStyle(MutableStylePropertySet* style, CSSPropertyID propertyID, CSSValueID identifier)
{
DCHECK(isStyledElement());
- style->setProperty(propertyID, CSSPrimitiveValue::createIdentifier(identifier));
+ style->setProperty(propertyID, *CSSPrimitiveValue::createIdentifier(identifier));
}
void Element::addPropertyToPresentationAttributeStyle(MutableStylePropertySet* style, CSSPropertyID propertyID, double value, CSSPrimitiveValue::UnitType unit)
{
DCHECK(isStyledElement());
- style->setProperty(propertyID, CSSPrimitiveValue::create(value, unit));
+ style->setProperty(propertyID, *CSSPrimitiveValue::create(value, unit));
}
void Element::addPropertyToPresentationAttributeStyle(MutableStylePropertySet* style, CSSPropertyID propertyID, const String& value)
@@ -3700,7 +3700,7 @@ void Element::addPropertyToPresentationAttributeStyle(MutableStylePropertySet* s
void Element::addPropertyToPresentationAttributeStyle(MutableStylePropertySet* style, CSSPropertyID propertyID, const CSSValue* value)
{
DCHECK(isStyledElement());
- style->setProperty(propertyID, value);
+ style->setProperty(propertyID, *value);
}
bool Element::supportsStyleSharing() const
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.h ('k') | third_party/WebKit/Source/core/editing/EditingStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698