Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: third_party/WebKit/Source/core/css/StylePropertySet.cpp

Issue 2233333002: Made StylePropertySet::setProperty take a const CSSValue& instead of ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/StylePropertySet.h ('k') | third_party/WebKit/Source/core/dom/Element.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/StylePropertySet.cpp
diff --git a/third_party/WebKit/Source/core/css/StylePropertySet.cpp b/third_party/WebKit/Source/core/css/StylePropertySet.cpp
index a3bcaea4e3a7eee79e71589df7c046f835ae523e..42c1d084450bd2935f6ba9b97dc7526a65046829 100644
--- a/third_party/WebKit/Source/core/css/StylePropertySet.cpp
+++ b/third_party/WebKit/Source/core/css/StylePropertySet.cpp
@@ -309,18 +309,18 @@ bool MutableStylePropertySet::setProperty(const AtomicString& customPropertyName
return CSSParser::parseValueForCustomProperty(this, customPropertyName, value, important, contextStyleSheet);
}
-void MutableStylePropertySet::setProperty(CSSPropertyID propertyID, const CSSValue* value, bool important)
+void MutableStylePropertySet::setProperty(CSSPropertyID propertyID, const CSSValue& value, bool important)
{
StylePropertyShorthand shorthand = shorthandForProperty(propertyID);
if (!shorthand.length()) {
- setProperty(CSSProperty(propertyID, *value, important));
+ setProperty(CSSProperty(propertyID, value, important));
return;
}
removePropertiesInSet(shorthand.properties(), shorthand.length());
for (unsigned i = 0; i < shorthand.length(); ++i)
- m_propertyVector.append(CSSProperty(shorthand.properties()[i], *value, important));
+ m_propertyVector.append(CSSProperty(shorthand.properties()[i], value, important));
}
bool MutableStylePropertySet::setProperty(const CSSProperty& property, CSSProperty* slot)
« no previous file with comments | « third_party/WebKit/Source/core/css/StylePropertySet.h ('k') | third_party/WebKit/Source/core/dom/Element.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698