Remove pyauto tests.

Remove pyauto tests.

BUG=224072
R=avi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261240

[Avi (use Gerrit), 2014-04-02 20:24:14]

lgtm

[baxley, 2014-04-07 22:17:15]

NOT LGTM. Please revert.

This CL deleted the I-Spy framework and its dependencies which are used by
Chrome mobile.

I-Spy lives in:
chrome/test/functional/ispy

[craigdh, 2014-04-07 22:30:06]

On 2014/04/07 22:17:15, baxley wrote:
> NOT LGTM. Please revert.
> 
> This CL deleted the I-Spy framework and its dependencies which are used by
> Chrome mobile.
> 
> I-Spy lives in:
> chrome/test/functional/ispy

Looks like this also deleted the webpagereplay script (used in multiple places,
including telemetry). I believe the cros network testing code is also deleted
here, which has nothing to do with pyauto. I suspect there may be other things
I'm not noticing.

[craigdh, 2014-04-07 22:52:50]

+krisr to comment on whether the ap_lab/ scripts are still in use.

[jam, 2014-04-07 22:54:12]

On 2014/04/07 22:30:06, craigdh wrote:
> On 2014/04/07 22:17:15, baxley wrote:
> > NOT LGTM. Please revert.

I won't revert, but I can bring it back.

> > 
> > This CL deleted the I-Spy framework and its dependencies which are used by
> > Chrome mobile.
> > 
> > I-Spy lives in:
> > chrome/test/functional/ispy

I see, I can bring back ispy. Since it was in chrome/test/functional, it looked
related to pyauto tests which is why it was deleted.

Where should I bring it back to?

> 
> Looks like this also deleted the webpagereplay script (used in multiple
places,
> including telemetry). I believe the cros network testing code is also deleted
> here, which has nothing to do with pyauto. I suspect there may be other things
> I'm not noticing.

I brought back that one file already.

[craigdh, 2014-04-07 22:59:41]

On 2014/04/07 22:54:12, jam wrote:
> 
> I see, I can bring back ispy. Since it was in chrome/test/functional, it
looked
> related to pyauto tests which is why it was deleted.
> 
> Where should I bring it back to?
> 

It'll probably be best to bring it back here, it's referenced from both the
Clank and Bling repos. Then we can coordinate landing a cross-repo cl to move it
while keeping the bots happy.

[jam, 2014-04-07 23:02:22]

On 2014/04/07 22:59:41, craigdh wrote:
> On 2014/04/07 22:54:12, jam wrote:
> > 
> > I see, I can bring back ispy. Since it was in chrome/test/functional, it
> looked
> > related to pyauto tests which is why it was deleted.
> > 
> > Where should I bring it back to?
> > 
> 
> It'll probably be best to bring it back here, it's referenced from both the
> Clank and Bling repos. Then we can coordinate landing a cross-repo cl to move
it
> while keeping the bots happy.

Mike had just chatted with me and we agreed to put it in chrome/test/ispy. I had
already landed it there.

[jam, 2014-04-07 23:05:12]

On 2014/04/07 23:02:22, jam wrote:
> On 2014/04/07 22:59:41, craigdh wrote:
> > On 2014/04/07 22:54:12, jam wrote:
> > > 
> > > I see, I can bring back ispy. Since it was in chrome/test/functional, it
> > looked
> > > related to pyauto tests which is why it was deleted.
> > > 
> > > Where should I bring it back to?
> > > 
> > 
> > It'll probably be best to bring it back here, it's referenced from both the
> > Clank and Bling repos. Then we can coordinate landing a cross-repo cl to
move
> it
> > while keeping the bots happy.
> 
> Mike had just chatted with me and we agreed to put it in chrome/test/ispy. I
had
> already landed it there.

note: for the future, this is the problems faced when code outside the chrome
repo depends on the structure of files in the chrome repo. Since chrome devs
can't see these hidden buildbots, they can't maintain a structure that's
depended on externally. so unless clank/bling can bring the tests that need this
code into the chromium repository, they will continue paying this cost.

I don't even see why this code is in the chromium repo in the first place, if
it's only used by internal blink/clank repos? Why not just put it in an internal
repo that's used by both?

[klundberg, 2014-04-07 23:24:46]

On 2014/04/07 23:05:12, jam wrote:
> On 2014/04/07 23:02:22, jam wrote:
> > On 2014/04/07 22:59:41, craigdh wrote:
> > > On 2014/04/07 22:54:12, jam wrote:
> > > > 
> > > > I see, I can bring back ispy. Since it was in chrome/test/functional, it
> > > looked
> > > > related to pyauto tests which is why it was deleted.
> > > > 
> > > > Where should I bring it back to?
> > > > 
> > > 
> > > It'll probably be best to bring it back here, it's referenced from both
the
> > > Clank and Bling repos. Then we can coordinate landing a cross-repo cl to
> move
> > it
> > > while keeping the bots happy.
> > 
> > Mike had just chatted with me and we agreed to put it in chrome/test/ispy. I
> had
> > already landed it there.
> 
> note: for the future, this is the problems faced when code outside the chrome
> repo depends on the structure of files in the chrome repo. Since chrome devs
> can't see these hidden buildbots, they can't maintain a structure that's
> depended on externally. so unless clank/bling can bring the tests that need
this
> code into the chromium repository, they will continue paying this cost.
> 
> I don't even see why this code is in the chromium repo in the first place, if
> it's only used by internal blink/clank repos? Why not just put it in an
internal
> repo that's used by both?

There is nothing preventing ispy from being used by chromium. 
It just happens to be that the mobile platforms are the first ones to use this
tool.