Make GetBestPageForOnlineURL async

Make GetBestPageForOnlineURL async

The sync version OfflinePageModel::GetBestPageForOnlineURL
is removed. The async version OfflinePageUtils::GetOfflineURLForOnlineURL
is added.

BUG=none

Committed: https://crrev.com/b76ea4265490fca01a94988397262f13e7bd220d
Cr-Commit-Position: refs/heads/master@{#411230}

[jianli, 2016-08-08 23:04:14]

jianli@chromium.org changed reviewers:
+ fgorski@chromium.org

[jianli, 2016-08-09 22:49:48]

Description was changed from

==========
Remove OfflinePageModel::GetBestPageForOnlineURL

This is not longer needed after removing
OfflinePageUtils::GetOfflineURLForOnlineURL

BUG=none
==========

to

==========
Make GetBestPageForOnlineURL async

The sync version OfflinePageModel::GetBestPageForOnlineURL
is removed. The async version OfflinePageUtils::GetOfflineURLForOnlineURL
is added.


BUG=none
==========

[jianli, 2016-08-09 22:50:00]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[jianli, 2016-08-09 22:50:17]

Change to make GetBestPageForOnlineURL async

[commit-bot: I haz the power, 2016-08-09 22:50:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-08-09 23:30:45]

fgorski@chromium.org changed reviewers:
+ dimich@chromium.org

[fgorski, 2016-08-09 23:30:45]

lgtm on my part.
I think you should let Dmitry take a look and have a say about TabID related
string->int move.

[commit-bot: I haz the power, 2016-08-09 23:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 23:46:23]

Dry run: This issue passed the CQ dry run.

[Dmitry Titov, 2016-08-10 02:56:37]

lgtm with mostly naming nits.
Move to int TabId ok.

https://codereview.chromium.org/2225213002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/offline_page_tab_helper.h (right):

https://codereview.chromium.org/2225213002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/offline_page_tab_helper.h:99: void
GetBestPageForOnlineURLDone(
the name doesn't match what this method does now. 
Maybe ContinueRedirectToOfflinePage?

https://codereview.chromium.org/2225213002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/offline_page_utils.h (right):

https://codereview.chromium.org/2225213002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/offline_page_utils.h:29: // page will be
preferred over an older one.
please add info to the comment on why tab_id is passed in.

Also, the naming is weird. "best" from which point of view? I think this is
selecting a page for automatic redirect to offline page, perhaps the name should
reflect that. Maybe GetOfflinePageForBrowserRedirect()?

[jianli, 2016-08-11 00:33:27]

https://codereview.chromium.org/2225213002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/offline_page_tab_helper.h (right):

https://codereview.chromium.org/2225213002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/offline_page_tab_helper.h:99: void
GetBestPageForOnlineURLDone(
On 2016/08/10 02:56:37, Dmitry Titov wrote:
> the name doesn't match what this method does now. 
> Maybe ContinueRedirectToOfflinePage?

Per discussion, changed to SelectPageForOnlineURLDone.

https://codereview.chromium.org/2225213002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/offline_page_utils.h (right):

https://codereview.chromium.org/2225213002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/offline_page_utils.h:29: // page will be
preferred over an older one.
On 2016/08/10 02:56:37, Dmitry Titov wrote:
> please add info to the comment on why tab_id is passed in.
> 
> Also, the naming is weird. "best" from which point of view? I think this is
> selecting a page for automatic redirect to offline page, perhaps the name
should
> reflect that. Maybe GetOfflinePageForBrowserRedirect()?

Per discussion, renamed to SelectPageForOnlineURL. Also added comment for
tab_id.

[jianli, 2016-08-11 00:33:37]

The CQ bit was checked by jianli@chromium.org

[jianli, 2016-08-11 00:33:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dimich@chromium.org,
fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/2225213002/#ps40001
(title: "Address feedback")

[commit-bot: I haz the power, 2016-08-11 00:34:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 02:31:12]

Description was changed from

==========
Make GetBestPageForOnlineURL async

The sync version OfflinePageModel::GetBestPageForOnlineURL
is removed. The async version OfflinePageUtils::GetOfflineURLForOnlineURL
is added.


BUG=none
==========

to

==========
Make GetBestPageForOnlineURL async

The sync version OfflinePageModel::GetBestPageForOnlineURL
is removed. The async version OfflinePageUtils::GetOfflineURLForOnlineURL
is added.


BUG=none
==========

[commit-bot: I haz the power, 2016-08-11 02:31:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-11 02:33:12]

Description was changed from

==========
Make GetBestPageForOnlineURL async

The sync version OfflinePageModel::GetBestPageForOnlineURL
is removed. The async version OfflinePageUtils::GetOfflineURLForOnlineURL
is added.


BUG=none
==========

to

==========
Make GetBestPageForOnlineURL async

The sync version OfflinePageModel::GetBestPageForOnlineURL
is removed. The async version OfflinePageUtils::GetOfflineURLForOnlineURL
is added.

BUG=none

Committed: https://crrev.com/b76ea4265490fca01a94988397262f13e7bd220d
Cr-Commit-Position: refs/heads/master@{#411230}
==========

[commit-bot: I haz the power, 2016-08-11 02:33:14]

Patchset 3 (id:??) landed as
https://crrev.com/b76ea4265490fca01a94988397262f13e7bd220d
Cr-Commit-Position: refs/heads/master@{#411230}