components/offline_pages/stub_offline_page_model.cc - Issue 2225213002: Make GetBestPageForOnlineURL async

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/stub_offline_page_model.cc

Issue 2225213002: Make GetBestPageForOnlineURL async (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/stub_offline_page_model.cc

diff --git a/components/offline_pages/stub_offline_page_model.cc b/components/offline_pages/stub_offline_page_model.cc

index 9d00e46a1993da488bfb75ac168b07b67824762c..68119ad8bd34a7d5c2fe6764d40296c86a894336 100644

--- a/components/offline_pages/stub_offline_page_model.cc

+++ b/components/offline_pages/stub_offline_page_model.cc

@@ -58,9 +58,6 @@ const OfflinePageItem* StubOfflinePageModel::MaybeGetPageByOfflineURL(

void StubOfflinePageModel::GetPagesByOnlineURL(

const GURL& online_url,

const MultipleOfflinePageItemCallback& callback) {}

-void StubOfflinePageModel::GetBestPageForOnlineURL(

- const GURL& online_url,

- const SingleOfflinePageItemCallback callback) {}

const OfflinePageItem* StubOfflinePageModel::MaybeGetBestPageForOnlineURL(

const GURL& online_url) const {

return nullptr;

« no previous file with comments | « components/offline_pages/stub_offline_page_model.h ('k') | no next file » | no next file with comments »