components/offline_pages/offline_page_model_impl.h - Issue 2225213002: Make GetBestPageForOnlineURL async

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model_impl.h

Issue 2225213002: Make GetBestPageForOnlineURL async (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/offline_page_model_impl.h

diff --git a/components/offline_pages/offline_page_model_impl.h b/components/offline_pages/offline_page_model_impl.h

index b93a227ebf40a5f09029fd8ffdbd3921eae29da0..fe165386b65ac80ed93e7740887c4eab83f60200 100644

--- a/components/offline_pages/offline_page_model_impl.h

+++ b/components/offline_pages/offline_page_model_impl.h

@@ -101,9 +101,6 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {

void GetPagesByOnlineURL(

const GURL& online_url,

const MultipleOfflinePageItemCallback& callback) override;

- void GetBestPageForOnlineURL(

- const GURL& online_url,

- const SingleOfflinePageItemCallback callback) override;

const OfflinePageItem* MaybeGetBestPageForOnlineURL(

const GURL& online_url) const override;

void CheckMetadataConsistency() override;

@@ -157,9 +154,6 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {

void GetPageByOfflineURLWhenLoadDone(

const GURL& offline_url,

const SingleOfflinePageItemCallback& callback) const;

- void GetBestPageForOnlineURLWhenLoadDone(

- const GURL& online_url,

- const SingleOfflinePageItemCallback& callback) const;

void MarkPageAccessedWhenLoadDone(int64_t offline_id);

void CheckMetadataConsistencyWhenLoadDone();