Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2225213002: Make GetBestPageForOnlineURL async (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.cc
diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc
index a4d63b2595aa929393db9452dd9373ae7f60891c..c97b2967fb1ec9798c93c2e239f6d509caf630da 100644
--- a/components/offline_pages/offline_page_model_impl.cc
+++ b/components/offline_pages/offline_page_model_impl.cc
@@ -566,20 +566,6 @@ const OfflinePageItem* OfflinePageModelImpl::MaybeGetPageByOfflineURL(
return nullptr;
}
-void OfflinePageModelImpl::GetBestPageForOnlineURL(
- const GURL& online_url,
- const SingleOfflinePageItemCallback callback) {
- RunWhenLoaded(
- base::Bind(&OfflinePageModelImpl::GetBestPageForOnlineURLWhenLoadDone,
- weak_ptr_factory_.GetWeakPtr(), online_url, callback));
-}
-
-void OfflinePageModelImpl::GetBestPageForOnlineURLWhenLoadDone(
- const GURL& online_url,
- const SingleOfflinePageItemCallback& callback) const {
- callback.Run(MaybeGetBestPageForOnlineURL(online_url));
-}
-
void OfflinePageModelImpl::GetPagesByOnlineURL(
const GURL& online_url,
const MultipleOfflinePageItemCallback& callback) {
« no previous file with comments | « components/offline_pages/offline_page_model_impl.h ('k') | components/offline_pages/stub_offline_page_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698