chrome/browser/android/offline_pages/offline_page_bridge.h - Issue 2225213002: Make GetBestPageForOnlineURL async

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.h

Issue 2225213002: Make GetBestPageForOnlineURL async (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/offline_pages/offline_page_bridge.h

diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.h b/chrome/browser/android/offline_pages/offline_page_bridge.h

index 5dbe1cbd783063be541116f5ecba02536171ff3e..5f9c28fa2b3012eacfcc44350ae7a5605c5b988c 100644

--- a/chrome/browser/android/offline_pages/offline_page_bridge.h

+++ b/chrome/browser/android/offline_pages/offline_page_bridge.h

@@ -66,10 +66,12 @@ class OfflinePageBridge : public OfflinePageModel::Observer,

const base::android::JavaParamRef<jobject>& obj,

jlong offline_id);

- base::android::ScopedJavaLocalRef<jobject> GetBestPageForOnlineURL(

+ void SelectPageForOnlineUrl(

JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj,

- const base::android::JavaParamRef<jstring>& online_url);

+ const base::android::JavaParamRef<jstring>& j_online_url,

+ int tab_id,

+ const base::android::JavaParamRef<jobject>& j_callback_obj);

void GetPageByOfflineUrl(

JNIEnv* env,