Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: chrome/browser/android/offline_pages/offline_page_tab_helper.h

Issue 2225213002: Make GetBestPageForOnlineURL async (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_tab_helper.h
diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper.h b/chrome/browser/android/offline_pages/offline_page_tab_helper.h
index 3a9b3e5fbab3dc963cd6916bc0fe8828c8f09a60..6bf460b072ceeafb3ef5662e8ecdf2edb6552e56 100644
--- a/chrome/browser/android/offline_pages/offline_page_tab_helper.h
+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper.h
@@ -32,7 +32,7 @@ class OfflinePageTabHelper :
public:
virtual ~Delegate() {}
virtual bool GetTabId(content::WebContents* web_contents,
- std::string* tab_id) const = 0;
+ int* tab_id) const = 0;
virtual base::Time Now() const = 0;
};
@@ -94,12 +94,12 @@ class OfflinePageTabHelper :
// redirect to that offline page, and caching metadata of that page locally.
// RedirectResult is accumulated along the codepath to reflect the overall
// result of redirection - and be reported to UMA at the end.
- void GetPagesForRedirectToOffline(RedirectResult result,
- const GURL& online_url);
- void SelectBestPageForRedirectToOffline(
+ void GetBestPageForRedirectToOffline(RedirectResult result,
+ const GURL& online_url);
+ void SelectPageForOnlineURLDone(
RedirectResult result,
const GURL& online_url,
- const MultipleOfflinePageItemResult& pages);
+ const OfflinePageItem* offline_page);
void TryRedirectToOffline(RedirectResult result,
const GURL& from_url,
const OfflinePageItem& offline_page);

Powered by Google App Engine
This is Rietveld 408576698