Moves CustomFrameViewAsh to common

Moves CustomFrameViewAsh to common

As part of this I'm introducing a pure virtual interface for
ImmersiveFullscreenController. I'm not entirely positive I'll need
this interface long term, but I'll definitely need it in the short
term.

BUG=634972, 548435
TEST=none
R=jamescook@chromium.org

Committed: https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817
Cr-Commit-Position: refs/heads/master@{#410363}

[James Cook, 2016-08-05 23:40:36]

LGTM

https://codereview.chromium.org/2222653002/diff/60001/ash/common/wm/immersive...
File ash/common/wm/immersive/wm_immersive_fullscreen_controller.h (right):

https://codereview.chromium.org/2222653002/diff/60001/ash/common/wm/immersive...
ash/common/wm/immersive/wm_immersive_fullscreen_controller.h:1: // Copyright
2016 The Chromium Authors. All rights reserved.
optional thought: I'm not sure it's worth it to create another subdirectory for
"immersive". //ash/common/wm/immersive/ is kinda deep, and it only has a few
files.

https://codereview.chromium.org/2222653002/diff/60001/ash/common/wm/immersive...
ash/common/wm/immersive/wm_immersive_fullscreen_controller.h:40: views::Widget*
widget,
nit: Document or rename this to indicate which widget it is supposed to be.

[sky, 2016-08-06 15:32:47]

https://codereview.chromium.org/2222653002/diff/60001/ash/common/wm/immersive...
File ash/common/wm/immersive/wm_immersive_fullscreen_controller.h (right):

https://codereview.chromium.org/2222653002/diff/60001/ash/common/wm/immersive...
ash/common/wm/immersive/wm_immersive_fullscreen_controller.h:1: // Copyright
2016 The Chromium Authors. All rights reserved.
On 2016/08/05 23:40:36, James Cook wrote:
> optional thought: I'm not sure it's worth it to create another subdirectory
for
> "immersive". //ash/common/wm/immersive/ is kinda deep, and it only has a few
> files.

Ya, I don't particularly like the depth either. OTOH I have a feeling there are
going to be more files ending up here (there is already two in the parent
directory I want to move here).

https://codereview.chromium.org/2222653002/diff/60001/ash/common/wm/immersive...
ash/common/wm/immersive/wm_immersive_fullscreen_controller.h:40: views::Widget*
widget,
On 2016/08/05 23:40:36, James Cook wrote:
> nit: Document or rename this to indicate which widget it is supposed to be.

Done.

[sky, 2016-08-06 15:33:21]

The CQ bit was checked by sky@chromium.org

[sky, 2016-08-06 15:33:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2222653002/#ps80001
(title: "comment")

[commit-bot: I haz the power, 2016-08-06 15:33:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 15:39:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 15:39:03]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[sky, 2016-08-08 14:50:40]

The CQ bit was checked by sky@chromium.org

[sky, 2016-08-08 14:50:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2222653002/#ps100001
(title: "merge")

[commit-bot: I haz the power, 2016-08-08 14:50:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 15:40:15]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-08 15:42:13]

Description was changed from

==========
Moves CustomFrameViewAsh to common

As part of this I'm introducing a pure virtual interface for
ImmersiveFullscreenController. I'm not entirely positive I'll need
this interface long term, but I'll definitely need it in the short
term.

BUG=634972,548435
TEST=none
R=jamescook@chromium.org
==========

to

==========
Moves CustomFrameViewAsh to common

As part of this I'm introducing a pure virtual interface for
ImmersiveFullscreenController. I'm not entirely positive I'll need
this interface long term, but I'll definitely need it in the short
term.

BUG=634972,548435
TEST=none
R=jamescook@chromium.org

Committed: https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817
Cr-Commit-Position: refs/heads/master@{#410363}
==========

[commit-bot: I haz the power, 2016-08-08 15:42:14]

Patchset 6 (id:??) landed as
https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817
Cr-Commit-Position: refs/heads/master@{#410363}