Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2219673005: [DevTools] Provide default implementation of V8InspectorClient methods. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Provide default implementation of V8InspectorClient methods. Drive-by: cleanup of interface of ThreadDebugger and friends. BUG=631162 Committed: https://crrev.com/7f81088d47e816a710a1a3562f114334cc601617 Cr-Commit-Position: refs/heads/master@{#410463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -95 lines) Patch
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 3 chunks +9 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 3 chunks +13 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h View 3 chunks +2 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp View 3 chunks +3 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h View 1 chunk +28 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 4 months ago (2016-08-06 01:39:38 UTC) #2
pfeldman
lgtm
4 years, 4 months ago (2016-08-08 17:25:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219673005/1
4 years, 4 months ago (2016-08-08 17:40:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 21:23:36 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 21:25:26 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7f81088d47e816a710a1a3562f114334cc601617
Cr-Commit-Position: refs/heads/master@{#410463}

Powered by Google App Engine
This is Rietveld 408576698