Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h

Issue 2219673005: [DevTools] Provide default implementation of V8InspectorClient methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h b/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h
index b9aade4b951ef711cb1f75f2278552cb08b14685..fc5426ba7c695e35da63dd5f7887a382f2da248a 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h
@@ -7,7 +7,6 @@
#include "platform/inspector_protocol/Platform.h"
#include "platform/v8_inspector/public/V8InspectorClient.h"
-#include "platform/v8_inspector/public/V8InspectorSession.h"
#include <v8.h>
@@ -20,13 +19,12 @@ class FrontendChannel;
}
class V8Inspector;
-class V8HeapProfilerAgent;
-class V8ProfilerAgent;
+class V8InspectorSession;
class SimpleInspector : public V8InspectorClient {
public:
SimpleInspector(v8::Isolate*, v8::Local<v8::Context>);
- ~SimpleInspector();
+ ~SimpleInspector() override;
// Transport interface.
void connectFrontend(protocol::FrontendChannel*);
@@ -35,35 +33,10 @@ public:
void notifyContextDestroyed();
private:
- String16 valueSubtype(v8::Local<v8::Value>) override;
- bool formatAccessorsAsProperties(v8::Local<v8::Value>) override;
- void muteMetrics(int) override { }
- void unmuteMetrics(int) override { }
- double currentTimeMS() override { return 0; };
-
v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId) override;
- void beginEnsureAllContextsInGroup(int contextGroupId) override { }
- void endEnsureAllContextsInGroup(int contextGroupId) override { }
- void beginUserGesture() override { }
- void endUserGesture() override { }
- bool isInspectableHeapObject(v8::Local<v8::Object>) override { return true; }
- void consoleTime(const String16& title) override { }
- void consoleTimeEnd(const String16& title) override { }
- void consoleTimeStamp(const String16& title) override { }
- void consoleAPIMessage(int contextGroupId, V8ConsoleAPIType, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) override { }
- v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) override
- {
- return v8::MaybeLocal<v8::Value>();
- }
- void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override { }
- void startRepeatingTimer(double, TimerCallback, void* data) override { }
- void cancelTimer(void* data) override { }
- bool canExecuteScripts(int) override { return true; }
- void resumeStartup(int) override { }
std::unique_ptr<V8Inspector> m_inspector;
std::unique_ptr<V8InspectorSession> m_session;
- String16 m_state;
v8::Local<v8::Context> m_context;
};

Powered by Google App Engine
This is Rietveld 408576698