[DevTools] Provide default implementation of V8InspectorClient methods.

third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h
index 81a438ae3b17b76209ac8e1de9a2b6d635825e78..27495ae9884b0bbcbb918621904051af3d3cd223 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h
@@ -19,35 +19,39 @@ enum class V8ConsoleAPIType { kClear, kDebug, kLog, kInfo, kWarning, kError };
 class PLATFORM_EXPORT V8InspectorClient {
 public:
     virtual ~V8InspectorClient() { }
-    virtual void runMessageLoopOnPause(int contextGroupId) = 0;
-    virtual void quitMessageLoopOnPause() = 0;
-    virtual void muteMetrics(int contextGroupId) = 0;
-    virtual void unmuteMetrics(int contextGroupId) = 0;
-    virtual void beginUserGesture() = 0;
-    virtual void endUserGesture() = 0;
-    virtual String16 valueSubtype(v8::Local<v8::Value>) = 0;
-    virtual bool formatAccessorsAsProperties(v8::Local<v8::Value>) = 0;
-    virtual double currentTimeMS() = 0;
-    virtual v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId) = 0;
-    virtual bool isInspectableHeapObject(v8::Local<v8::Object>) = 0;
-    virtual void beginEnsureAllContextsInGroup(int contextGroupId) = 0;
-    virtual void endEnsureAllContextsInGroup(int contextGroupId) = 0;
-    // TODO(dgozman): this was added to support service worker shadow page. We should not connect at all.
-    virtual bool canExecuteScripts(int contextGroupId) = 0;
-    virtual void resumeStartup(int contextGroupId) = 0;
 
-    virtual void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) = 0;
+    virtual void runMessageLoopOnPause(int contextGroupId) { }
+    virtual void quitMessageLoopOnPause() { }
+    virtual void resumeStartup(int contextGroupId) { }
+
+    virtual void muteMetrics(int contextGroupId) { }
+    virtual void unmuteMetrics(int contextGroupId) { }
+
+    virtual void beginUserGesture() { }
+    virtual void endUserGesture() { }
 
-    virtual void consoleTime(const String16& title) = 0;
-    virtual void consoleTimeEnd(const String16& title) = 0;
-    virtual void consoleTimeStamp(const String16& title) = 0;
-    virtual void consoleAPIMessage(int contextGroupId, V8ConsoleAPIType, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) = 0;
+    virtual String16 valueSubtype(v8::Local<v8::Value>) { return String16(); }
+    virtual bool formatAccessorsAsProperties(v8::Local<v8::Value>) { return false; }
+    virtual bool isInspectableHeapObject(v8::Local<v8::Object>) { return true; }
 
-    virtual v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) = 0;
+    virtual v8::Local<v8::Context> ensureDefaultContextInGroup(int contextGroupId) { return v8::Local<v8::Context>(); }
+    virtual void beginEnsureAllContextsInGroup(int contextGroupId) { }
+    virtual void endEnsureAllContextsInGroup(int contextGroupId) { }
 
+    virtual void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) { }
+    virtual void consoleAPIMessage(int contextGroupId, V8ConsoleAPIType, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) { }
+    virtual v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) { return v8::MaybeLocal<v8::Value>(); }
+
+    virtual void consoleTime(const String16& title) { }
+    virtual void consoleTimeEnd(const String16& title) { }
+    virtual void consoleTimeStamp(const String16& title) { }
+    virtual double currentTimeMS() { return 0; }
     typedef void (*TimerCallback)(void*);
-    virtual void startRepeatingTimer(double, TimerCallback, void* data) = 0;
-    virtual void cancelTimer(void* data) = 0;
+    virtual void startRepeatingTimer(double, TimerCallback, void* data) { }
+    virtual void cancelTimer(void* data) { }
+
+    // TODO(dgozman): this was added to support service worker shadow page. We should not connect at all.
+    virtual bool canExecuteScripts(int contextGroupId) { return true; }
 };
 
 } // namespace blink