Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h

Issue 2219673005: [DevTools] Provide default implementation of V8InspectorClient methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
index 7f93b9b274c24cb45018bb2b15bebf13af717d4a..115343b72d6ea2ea347aac9642906c274a8ca8f0 100644
--- a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
@@ -48,14 +48,16 @@ public:
~WorkerThreadDebugger() override;
static WorkerThreadDebugger* from(v8::Isolate*);
- void reportConsoleMessage(ExecutionContext*, MessageSource, MessageLevel, const String& message, SourceLocation*) override;
- int contextGroupId(ExecutionContext*) override;
+ bool isWorker() override { return true; }
int contextGroupId();
void contextCreated(v8::Local<v8::Context>);
void contextWillBeDestroyed(v8::Local<v8::Context>);
void exceptionThrown(ErrorEvent*);
- unsigned promiseRejected(v8::Local<v8::Context>, const String16& errorMessage, v8::Local<v8::Value> exception, std::unique_ptr<SourceLocation>);
+
+private:
+ int contextGroupId(ExecutionContext*) override;
+ void reportConsoleMessage(ExecutionContext*, MessageSource, MessageLevel, const String& message, SourceLocation*) override;
// V8InspectorClient implementation.
void runMessageLoopOnPause(int contextGroupId) override;
@@ -67,11 +69,9 @@ public:
void endEnsureAllContextsInGroup(int contextGroupId) override;
bool canExecuteScripts(int contextGroupId) override;
void resumeStartup(int contextGroupId) override;
-
v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) override;
void consoleAPIMessage(int contextGroupId, V8ConsoleAPIType, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) override;
-private:
WorkerThread* m_workerThread;
};

Powered by Google App Engine
This is Rietveld 408576698