Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

Issue 2219673005: [DevTools] Provide default implementation of V8InspectorClient methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/ThreadDebugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
index 6d1fa37ced353de170370009162ced3df9b9bc81..296ed0ef12f6567f04df0e879f4f07d9f9262290 100644
--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
@@ -69,8 +69,6 @@ public:
bool isWorker() override { return false; }
bool isPaused() const { return m_paused; }
void setClientMessageLoop(std::unique_ptr<ClientMessageLoop>);
- void reportConsoleMessage(ExecutionContext*, MessageSource, MessageLevel, const String& message, SourceLocation*) override;
- int contextGroupId(ExecutionContext*) override;
// TODO(dgozman): by making this method virtual, we can move many methods to ThreadDebugger and avoid some duplication. Should be careful about performance.
int contextGroupId(LocalFrame*);
@@ -79,11 +77,10 @@ public:
void contextWillBeDestroyed(ScriptState*);
void exceptionThrown(ExecutionContext*, ErrorEvent*);
- void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override;
-
- v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) override;
-
private:
+ void reportConsoleMessage(ExecutionContext*, MessageSource, MessageLevel, const String& message, SourceLocation*) override;
+ int contextGroupId(ExecutionContext*) override;
+
// V8InspectorClient implementation.
void runMessageLoopOnPause(int contextGroupId) override;
void quitMessageLoopOnPause() override;
@@ -95,16 +92,17 @@ private:
bool canExecuteScripts(int contextGroupId) override;
void resumeStartup(int contextGroupId) override;
void consoleAPIMessage(int contextGroupId, V8ConsoleAPIType, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) override;
+ void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override;
+ v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) override;
+
+ static void querySelectorCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+ static void querySelectorAllCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+ static void xpathSelectorCallback(const v8::FunctionCallbackInfo<v8::Value>&);
std::unique_ptr<ClientMessageLoop> m_clientMessageLoop;
std::unique_ptr<InspectorTaskRunner> m_taskRunner;
bool m_paused;
-
static MainThreadDebugger* s_instance;
-
- static void querySelectorCallback(const v8::FunctionCallbackInfo<v8::Value>&);
- static void querySelectorAllCallback(const v8::FunctionCallbackInfo<v8::Value>&);
- static void xpathSelectorCallback(const v8::FunctionCallbackInfo<v8::Value>&);
};
} // namespace blink
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/ThreadDebugger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698