Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp

Issue 2219673005: [DevTools] Provide default implementation of V8InspectorClient methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp b/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp
index ebd9fe708937c90a6d7bc7e5e06df67e34fda412..7653fd65191f8729c1b1ef671fa31058c2ab4e0f 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp
@@ -6,9 +6,8 @@
#include "platform/v8_inspector/public/SimpleInspector.h"
#include "platform/inspector_protocol/DispatcherBase.h"
-#include "platform/v8_inspector/V8StringUtil.h"
#include "platform/v8_inspector/public/V8Inspector.h"
-#include "platform/v8_inspector/public/V8InspectorClient.h"
+#include "platform/v8_inspector/public/V8InspectorSession.h"
namespace blink {
@@ -24,19 +23,9 @@ SimpleInspector::~SimpleInspector()
disconnectFrontend();
}
-String16 SimpleInspector::valueSubtype(v8::Local<v8::Value> value)
-{
- return String16();
-}
-
-bool SimpleInspector::formatAccessorsAsProperties(v8::Local<v8::Value> value)
-{
- return false;
-}
-
void SimpleInspector::connectFrontend(protocol::FrontendChannel* channel)
{
- m_session = m_inspector->connect(1, channel, &m_state);
+ m_session = m_inspector->connect(1, channel, nullptr);
}
void SimpleInspector::disconnectFrontend()
@@ -50,7 +39,7 @@ void SimpleInspector::dispatchMessageFromFrontend(const String16& message)
m_session->dispatchProtocolMessage(message);
}
-v8::Local<v8::Context> SimpleInspector::ensureDefaultContextInGroup(int)
+v8::Local<v8::Context> SimpleInspector::ensureDefaultContextInGroup(int contextGroupId)
{
return m_context;
}

Powered by Google App Engine
This is Rietveld 408576698