Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2208733002: Command buffer: clear rect for a specific layer/level of the uncleared texture for CopyTexSubImage3D (Closed)

Created:
4 years, 4 months ago by yunchao
Modified:
4 years, 4 months ago
CC:
chromium-reviews, piman+watch_chromium.org, Yang Gu, yizhou.jiang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Command buffer: clear rect for a specific layer/level of the uncleared texture for CopyTexSubImage3D. BUG=631934, 636626 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : add layer to track texture cleared status for 3D/2D_ARRAY texture #

Patch Set 3 : num_uncleared_layers should be per mipmap level, not per the whole texture #

Patch Set 4 : fix bugs in gpu_unittests for mailbox_manager_unittest #

Patch Set 5 : add layer to GetLeveImage/SetLevelImage to support 3D/2D_ARRAY texture #

Patch Set 6 : clean the code, and fix coding style issues #

Patch Set 7 : fix bots failures #

Patch Set 8 : Do not assign a default value 0 to layer, UpdateMipCleared for all layers for 3D texture #

Unified diffs Side-by-side diffs Delta from patch set Stats (+628 lines, -291 lines) Patch
M gpu/command_buffer/service/framebuffer_manager.cc View 1 2 3 4 5 6 7 3 chunks +5 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 26 chunks +76 lines, -34 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 1 2 3 4 15 chunks +90 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager_sync.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/mailbox_manager_unittest.cc View 1 2 3 4 5 6 chunks +10 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 1 2 3 4 5 6 chunks +9 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 2 3 4 5 6 7 16 chunks +65 lines, -16 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 3 4 5 6 7 31 chunks +273 lines, -121 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 2 3 4 5 21 chunks +92 lines, -80 lines 0 comments Download
M gpu/ipc/service/stream_texture_android.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/android_deferred_rendering_backing_strategy.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/avda_codec_image.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/ipc/service/gpu_video_decode_accelerator.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 32 (32 generated)
yunchao
Description was changed from ========== Clear the uncleared texture for CopyTexSubImage3D BUG= ========== to ========== ...
4 years, 4 months ago (2016-08-03 15:23:17 UTC) #1
yunchao
Description was changed from ========== Clear the uncleared texture for CopyTexSubImage3D BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ...
4 years, 4 months ago (2016-08-03 15:25:42 UTC) #2
yunchao
yunchao.he@intel.com changed reviewers: + kbr@chromium.org, piman@chromium.org, qiankun.miao@intel.com, zmo@chromium.org
4 years, 4 months ago (2016-08-03 15:25:42 UTC) #3
yunchao
Patchset #1 (id:1) has been deleted
4 years, 4 months ago (2016-08-03 15:33:50 UTC) #4
yunchao
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
4 years, 4 months ago (2016-08-07 14:33:31 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208733002/80001
4 years, 4 months ago (2016-08-07 14:33:43 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-07 14:38:33 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/232580)
4 years, 4 months ago (2016-08-07 14:38:35 UTC) #8
yunchao
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
4 years, 4 months ago (2016-08-08 06:25:26 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208733002/100001
4 years, 4 months ago (2016-08-08 06:25:44 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-08 06:30:48 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/232684)
4 years, 4 months ago (2016-08-08 06:30:49 UTC) #12
yunchao
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
4 years, 4 months ago (2016-08-08 09:53:52 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208733002/120001
4 years, 4 months ago (2016-08-08 09:53:59 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-08 10:03:31 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/179397) linux_chromium_chromeos_ozone_rel_ng on ...
4 years, 4 months ago (2016-08-08 10:03:32 UTC) #16
yunchao
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
4 years, 4 months ago (2016-08-08 13:50:58 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208733002/140001
4 years, 4 months ago (2016-08-08 13:51:15 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-08 14:04:28 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/117851)
4 years, 4 months ago (2016-08-08 14:04:28 UTC) #20
yunchao
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
4 years, 4 months ago (2016-08-08 14:48:21 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208733002/160001
4 years, 4 months ago (2016-08-08 14:48:36 UTC) #22
yunchao
Patchset #7 (id:140001) has been deleted
4 years, 4 months ago (2016-08-08 15:42:35 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-08 16:43:29 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_gpu_tests_rel/builds/1883)
4 years, 4 months ago (2016-08-08 16:43:30 UTC) #25
yunchao
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
4 years, 4 months ago (2016-08-09 07:26:11 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208733002/180001
4 years, 4 months ago (2016-08-09 07:26:41 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-09 07:48:41 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/204141)
4 years, 4 months ago (2016-08-09 07:48:42 UTC) #29
yunchao
Description was changed from ========== Command buffer: Clear the uncleared texture for CopyTexSubImage3D BUG=631934 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ...
4 years, 4 months ago (2016-08-16 01:46:24 UTC) #30
yunchao
Description was changed from ========== Command buffer: Clear Rect/Layer of the uncleared texture for CopyTexSubImage3D ...
4 years, 4 months ago (2016-08-16 01:47:50 UTC) #31
yunchao
4 years, 4 months ago (2016-08-16 01:52:04 UTC) #32 
Description was changed from

==========
Command buffer: Clear Rect/Layer of the uncleared texture for CopyTexSubImage3D

BUG=631934, 636626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Command buffer: clear rect for a specific layer/level of the uncleared texture
for CopyTexSubImage3D.

BUG=631934, 636626
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

Powered by Google App Engine
This is Rietveld 408576698