Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: gpu/command_buffer/service/framebuffer_manager.cc

Issue 2208733002: Command buffer: clear rect for a specific layer/level of the uncleared texture for CopyTexSubImage3D (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do not assign a default value 0 to layer, UpdateMipCleared for all layers for 3D texture Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/framebuffer_manager.cc
diff --git a/gpu/command_buffer/service/framebuffer_manager.cc b/gpu/command_buffer/service/framebuffer_manager.cc
index acccab8cdd9b1ee71c747d32673c96e6694eec95..5ee017c36122597f1a62b82b179c7773823174de 100644
--- a/gpu/command_buffer/service/framebuffer_manager.cc
+++ b/gpu/command_buffer/service/framebuffer_manager.cc
@@ -208,7 +208,7 @@ class TextureAttachment
GLuint object_name() const override { return texture_ref_->client_id(); }
bool cleared() const override {
- return texture_ref_->texture()->IsLevelCleared(target_, level_);
+ return texture_ref_->texture()->IsLevelCleared(target_, level_, layer_);
}
void SetCleared(RenderbufferManager* /* renderbuffer_manager */,
@@ -216,11 +216,12 @@ class TextureAttachment
bool cleared) override {
DCHECK(texture_manager);
texture_manager->SetLevelCleared(
- texture_ref_.get(), target_, level_, cleared);
+ texture_ref_.get(), target_, level_, layer_, cleared);
}
bool IsPartiallyCleared() const override {
- return texture_ref_->texture()->IsLevelPartiallyCleared(target_, level_);
+ return texture_ref_->texture()->IsLevelPartiallyCleared(
+ target_, level_, layer_);
}
bool IsTextureAttachment() const override { return true; }
@@ -304,7 +305,7 @@ class TextureAttachment
std::string* signature) const override {
DCHECK(signature);
texture_manager->AddToSignature(
- texture_ref_.get(), target_, level_, signature);
+ texture_ref_.get(), target_, level_, layer_, signature);
}
bool FormsFeedbackLoop(TextureRef* texture,
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698