gpu/command_buffer/service/mailbox_manager_sync.cc - Issue 2208733002: Command buffer: clear rect for a specific layer/level of the uncleared texture for CopyTexSubImage3D

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/mailbox_manager_sync.cc

Issue 2208733002: Command buffer: clear rect for a specific layer/level of the uncleared texture for CopyTexSubImage3D (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Do not assign a default value 0 to layer, UpdateMipCleared for all layers for 3D texture Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc ('k') | gpu/command_buffer/service/mailbox_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/mailbox_manager_sync.cc

diff --git a/gpu/command_buffer/service/mailbox_manager_sync.cc b/gpu/command_buffer/service/mailbox_manager_sync.cc

index d07a3ddeb09b8bc903aeae41507d2a2747ac8d57..73125a42b6a7364226006d7ed9dfa069ee65886c 100644

--- a/gpu/command_buffer/service/mailbox_manager_sync.cc

+++ b/gpu/command_buffer/service/mailbox_manager_sync.cc

@@ -277,7 +277,7 @@ void MailboxManagerSync::UpdateDefinitionLocked(

if (SkipTextureWorkarounds(texture))

return;

- gl::GLImage* image = texture->GetLevelImage(texture->target(), 0);

+ gl::GLImage* image = texture->GetLevelImage(texture->target(), 0, 0);

TextureGroup* group = group_ref->group.get();

const TextureDefinition& definition = group->GetDefinition();

scoped_refptr<NativeImageBuffer> image_buffer = definition.image();