Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2207763003: Make mojo::internal::Buffer a non-virtual class. (Closed)

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), Fady Samuel, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@85_3_inline_validation_context
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make mojo::internal::Buffer a non-virtual class. BUG=None Committed: https://crrev.com/b01ff92c43d91c0d0a61c8b35645e23535aa92a4 Cr-Commit-Position: refs/heads/master@{#409706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -147 lines) Patch
M mojo/public/cpp/bindings/lib/buffer.h View 1 chunk +50 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/fixed_buffer.h View 1 chunk +4 lines, -48 lines 0 comments Download
M mojo/public/cpp/bindings/lib/fixed_buffer.cc View 1 chunk +6 lines, -37 lines 0 comments Download
M mojo/public/cpp/bindings/lib/message_buffer.h View 3 chunks +2 lines, -13 lines 0 comments Download
M mojo/public/cpp/bindings/lib/message_buffer.cc View 1 chunk +9 lines, -28 lines 0 comments Download
M mojo/public/cpp/bindings/lib/serialization.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/message.h View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_declaration.tmpl View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
yzshen1
Hi, Ken. Please take a look. It turns out that this change doesn't affect performance ...
4 years, 4 months ago (2016-08-03 18:12:19 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 4 months ago (2016-08-04 00:10:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207763003/1
4 years, 4 months ago (2016-08-04 01:57:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 02:32:50 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 02:34:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b01ff92c43d91c0d0a61c8b35645e23535aa92a4
Cr-Commit-Position: refs/heads/master@{#409706}

Powered by Google App Engine
This is Rietveld 408576698