mojo/public/cpp/bindings/lib/serialization.h - Issue 2207763003: Make mojo::internal::Buffer a non-virtual class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/serialization.h

Issue 2207763003: Make mojo::internal::Buffer a non-virtual class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@85_3_inline_validation_context

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/cpp/bindings/lib/serialization.h

diff --git a/mojo/public/cpp/bindings/lib/serialization.h b/mojo/public/cpp/bindings/lib/serialization.h

index 6d7dd8e5cde032a783c2167d2ef5849de60afce1..e51d5f98b89ee1d435cc1769883e8778db2f1515 100644

--- a/mojo/public/cpp/bindings/lib/serialization.h

+++ b/mojo/public/cpp/bindings/lib/serialization.h

@@ -11,7 +11,7 @@

#include "mojo/public/cpp/bindings/array_traits_standard.h"

#include "mojo/public/cpp/bindings/array_traits_stl.h"

#include "mojo/public/cpp/bindings/lib/array_serialization.h"

-#include "mojo/public/cpp/bindings/lib/fixed_buffer.h"

+#include "mojo/public/cpp/bindings/lib/buffer.h"

#include "mojo/public/cpp/bindings/lib/handle_interface_serialization.h"

#include "mojo/public/cpp/bindings/lib/map_serialization.h"

#include "mojo/public/cpp/bindings/lib/native_enum_serialization.h"

@@ -53,7 +53,7 @@ DataArrayType StructSerializeImpl(UserType* input) {

DCHECK(IsAligned(result_buffer));

}

- FixedBuffer buffer;

+ Buffer buffer;

buffer.Initialize(result_buffer, size);

typename MojomType::Struct::Data_* data = nullptr;

Serialize<MojomType>(*input, &buffer, &data, &context);

« no previous file with comments | « mojo/public/cpp/bindings/lib/message_buffer.cc ('k') | mojo/public/cpp/bindings/message.h » ('j') | no next file with comments »