mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl - Issue 2207763003: Make mojo::internal::Buffer a non-virtual class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

Issue 2207763003: Make mojo::internal::Buffer a non-virtual class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@85_3_inline_validation_context

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_declaration.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

index a2e57084edc55efd21b3d0e243e0716f9c05418b..b5f44622911f0c9ffea35e34b70a364ec8b6ada1 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl

@@ -2,11 +2,6 @@

{%- set class_name = struct.name ~ "_Data" %}

// static

-{{class_name}}* {{class_name}}::New(mojo::internal::Buffer* buf) {

- return new (buf->Allocate(sizeof({{class_name}}))) {{class_name}}();

-// static

bool {{class_name}}::Validate(

const void* data,

mojo::internal::ValidationContext* validation_context) {