mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl - Issue 2207763003: Make mojo::internal::Buffer a non-virtual class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl

Issue 2207763003: Make mojo::internal::Buffer a non-virtual class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@85_3_inline_validation_context

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl

index be2db4c952f15f766ad5c1135f83fc2f35616c94..d65854073187bfc6aed181e11d6a8d55407820b5 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl

@@ -6,7 +6,11 @@ class {{class_name}} {

public:

// Used to identify Mojom Union Data Classes.

typedef void MojomUnionDataType;

- static {{class_name}}* New(mojo::internal::Buffer* buf);

+ static {{class_name}}* New(mojo::internal::Buffer* buf) {

+ return new (buf->Allocate(sizeof({{class_name}}))) {{class_name}}();

+ }

{{class_name}}();

// Do nothing in the destructor since it won't be called.

~{{class_name}}() {}