Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: mojo/public/cpp/bindings/message.h

Issue 2207763003: Make mojo::internal::Buffer a non-virtual class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@85_3_inline_validation_context
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/message.h
diff --git a/mojo/public/cpp/bindings/message.h b/mojo/public/cpp/bindings/message.h
index e758432b9a953d5131d53c10509c71b1d4a7f52f..9077b04b0f625d0ef90674bb293511a441e09231 100644
--- a/mojo/public/cpp/bindings/message.h
+++ b/mojo/public/cpp/bindings/message.h
@@ -44,7 +44,9 @@ class Message {
// Transfers data and handles to |destination|.
void MoveTo(Message* destination);
- uint32_t data_num_bytes() const { return buffer_->data_num_bytes(); }
+ uint32_t data_num_bytes() const {
+ return static_cast<uint32_t>(buffer_->size());
+ }
// Access the raw bytes of the message.
const uint8_t* data() const {
@@ -86,8 +88,8 @@ class Message {
const uint8_t* payload() const { return data() + header()->num_bytes; }
uint8_t* mutable_payload() { return const_cast<uint8_t*>(payload()); }
uint32_t payload_num_bytes() const {
- DCHECK(buffer_->data_num_bytes() >= header()->num_bytes);
- size_t num_bytes = buffer_->data_num_bytes() - header()->num_bytes;
+ DCHECK(data_num_bytes() >= header()->num_bytes);
+ size_t num_bytes = data_num_bytes() - header()->num_bytes;
DCHECK(num_bytes <= std::numeric_limits<uint32_t>::max());
return static_cast<uint32_t>(num_bytes);
}

Powered by Google App Engine
This is Rietveld 408576698