Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2202423002: Mojo C++ bindings: inline validation context methods. (Closed)

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), Fady Samuel, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@85_2_inline_pointer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: inline validation context methods. This improves the mojo deserialization tests of cc_serialization_perftest by ~10%. BUG=624459 Committed: https://crrev.com/b0650ea5b9c43f27bc004a1accf74a1aedebeec1 Cr-Commit-Position: refs/heads/master@{#409341}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -49 lines) Patch
M mojo/public/cpp/bindings/lib/validation_context.h View 1 2 2 chunks +32 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_context.cc View 1 2 chunks +0 lines, -44 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (13 generated)
yzshen1
Average numbers from three runs of cc_perftests: =============================================== ' StructTraits deserialization: num runs in 2 ...
4 years, 4 months ago (2016-08-02 19:49:52 UTC) #5
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 4 months ago (2016-08-02 19:50:22 UTC) #7
yzshen1
Btw, this change also reduces the release build binary of mojo_public_bindings_unittests by ~8.5k bytes.
4 years, 4 months ago (2016-08-02 19:52:21 UTC) #10
Ken Rockot(use gerrit already)
lgtm
4 years, 4 months ago (2016-08-02 21:43:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202423002/40001
4 years, 4 months ago (2016-08-02 21:53:38 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-02 21:59:45 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 22:01:52 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b0650ea5b9c43f27bc004a1accf74a1aedebeec1
Cr-Commit-Position: refs/heads/master@{#409341}

Powered by Google App Engine
This is Rietveld 408576698