Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py

Issue 2203643002: [Findit] Use new mock for unittests. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@0708-pipeline-refactor
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py b/appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py
index 12b037fc1040d414d52cff948622a7dca19d5db5..eb054042171c667f2545e9155ac46b9737e48bcc 100644
--- a/appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py
+++ b/appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py
@@ -90,16 +90,16 @@ class StartTryJobOnDemandPipelineTest(wf_testcase.WaterfallTestCase):
self.assertEqual(list(result), [])
@mock.patch.object(start_try_job_on_demand_pipeline, 'try_job_util')
- def testNotScheduleTryJobIfDontNeedTryJob(self, mock_other):
- mock_other.NeedANewTryJob.return_value = False
+ def testNotScheduleTryJobIfDontNeedTryJob(self, mock_module):
+ mock_module.NeedANewTryJob.return_value = False
pipeline = start_try_job_on_demand_pipeline.StartTryJobOnDemandPipeline()
result = pipeline.run(
'm', 'b', 1, {}, {}, {}, True, False)
self.assertEqual(list(result), [])
@mock.patch.object(start_try_job_on_demand_pipeline, 'try_job_util')
- def testNotScheduleTryJobIfUnsupportedFailureType(self, mock_other):
- mock_other.NeedANewTryJob.return_value = True
+ def testNotScheduleTryJobIfUnsupportedFailureType(self, mock_module):
+ mock_module.NeedANewTryJob.return_value = True
try_job_type = failure_type.UNKNOWN
failure_info = {
'failure_type': try_job_type,
@@ -126,7 +126,7 @@ class StartTryJobOnDemandPipelineTest(wf_testcase.WaterfallTestCase):
self.assertEqual(list(result), [])
@mock.patch.object(start_try_job_on_demand_pipeline, 'try_job_util')
- def testCompileTryJob(self, mock_other):
+ def testCompileTryJob(self, mock_module):
master_name = 'm'
builder_name = 'b'
@@ -155,8 +155,8 @@ class StartTryJobOnDemandPipelineTest(wf_testcase.WaterfallTestCase):
bad_revision = 'r2'
WfTryJob.Create('m', 'b', 1).put()
- mock_other.NeedANewTryJob.return_value = True
- mock_other.GetFailedTargetsFromSignals.return_value = {}
+ mock_module.NeedANewTryJob.return_value = True
+ mock_module.GetFailedTargetsFromSignals.return_value = {}
self.MockPipeline(
start_try_job_on_demand_pipeline.ScheduleCompileTryJobPipeline,
@@ -186,7 +186,7 @@ class StartTryJobOnDemandPipelineTest(wf_testcase.WaterfallTestCase):
self.assertNotEqual(list(result), [])
@mock.patch.object(start_try_job_on_demand_pipeline, 'try_job_util')
- def testTestTryJob(self, mock_other):
+ def testTestTryJob(self, mock_module):
master_name = 'm'
builder_name = 'b'
@@ -231,8 +231,8 @@ class StartTryJobOnDemandPipelineTest(wf_testcase.WaterfallTestCase):
good_revision = 'r1'
bad_revision = 'r2'
- mock_other.NeedANewTryJob.return_value = True
- mock_other.GetFailedTargetsFromSignals.return_value = {}
+ mock_module.NeedANewTryJob.return_value = True
+ mock_module.GetFailedTargetsFromSignals.return_value = {}
self.MockPipeline(
start_try_job_on_demand_pipeline.ScheduleTestTryJobPipeline,

Powered by Google App Engine
This is Rietveld 408576698