appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py - Issue 2203643002: [Findit] Use new mock for unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py

Issue 2203643002: [Findit] Use new mock for unittests. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@0708-pipeline-refactor

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/test/schedule_test_try_job_pipeline_test.py ('k') | appengine/findit/waterfall/test/start_try_job_on_demand_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py

diff --git a/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py b/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py

index d6ea7b51da06b9b487d61803110577b96bbf974e..ed646402fc7dd76c50c75364e5cb548e00df49e8 100644

--- a/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py

+++ b/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py

@@ -58,7 +58,7 @@ class ScheduleTryjobPipelineTest(wf_testcase.WaterfallTestCase):

self.assertEqual(properties, expected_properties)

@mock.patch.object(schedule_try_job_pipeline, 'buildbucket_client')

- def testTriggerTryJob(self, mock_other):

+ def testTriggerTryJob(self, mock_module):

master_name = 'm'

builder_name = 'b'

response = {

@@ -69,7 +69,7 @@ class ScheduleTryjobPipelineTest(wf_testcase.WaterfallTestCase):

}

results = [(None, buildbucket_client.BuildbucketBuild(response['build']))]

- mock_other.TriggerTryJobs.return_value = results

+ mock_module.TriggerTryJobs.return_value = results

try_job_pipeline = ScheduleTryJobPipeline()

build_id = try_job_pipeline._TriggerTryJob(