Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: appengine/findit/waterfall/test/schedule_compile_try_job_pipeline_test.py

Issue 2203643002: [Findit] Use new mock for unittests. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@0708-pipeline-refactor
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import mock 5 import mock
6 6
7 from common.waterfall import buildbucket_client 7 from common.waterfall import buildbucket_client
8 from common.waterfall import failure_type 8 from common.waterfall import failure_type
9 from model.wf_try_job import WfTryJob 9 from model.wf_try_job import WfTryJob
10 from model.wf_try_job_data import WfTryJobData 10 from model.wf_try_job_data import WfTryJobData
(...skipping 22 matching lines...) Expand all
33 } 33 }
34 try_job_pipeline = ScheduleCompileTryJobPipeline() 34 try_job_pipeline = ScheduleCompileTryJobPipeline()
35 properties = try_job_pipeline._GetBuildProperties( 35 properties = try_job_pipeline._GetBuildProperties(
36 master_name, builder_name, build_number, 1, 2, 36 master_name, builder_name, build_number, 1, 2,
37 failure_type.COMPILE, None) 37 failure_type.COMPILE, None)
38 38
39 self.assertEqual(properties, expected_properties) 39 self.assertEqual(properties, expected_properties)
40 40
41 @mock.patch.object(schedule_try_job_pipeline, 'buildbucket_client') 41 @mock.patch.object(schedule_try_job_pipeline, 'buildbucket_client')
42 def testSuccessfullyScheduleNewTryJobForCompileWithSuspectedRevisions( 42 def testSuccessfullyScheduleNewTryJobForCompileWithSuspectedRevisions(
43 self, mock_other): 43 self, mock_module):
44 master_name = 'm' 44 master_name = 'm'
45 builder_name = 'b' 45 builder_name = 'b'
46 build_number = 223 46 build_number = 223
47 good_revision = 'rev1' 47 good_revision = 'rev1'
48 bad_revision = 'rev2' 48 bad_revision = 'rev2'
49 build_id = '1' 49 build_id = '1'
50 url = 'url' 50 url = 'url'
51 51
52 response = { 52 response = {
53 'build': { 53 'build': {
54 'id': build_id, 54 'id': build_id,
55 'url': url, 55 'url': url,
56 'status': 'SCHEDULED', 56 'status': 'SCHEDULED',
57 } 57 }
58 } 58 }
59 results = [(None, buildbucket_client.BuildbucketBuild(response['build']))] 59 results = [(None, buildbucket_client.BuildbucketBuild(response['build']))]
60 mock_other.TriggerTryJobs.return_value = results 60 mock_module.TriggerTryJobs.return_value = results
61 61
62 WfTryJob.Create(master_name, builder_name, build_number).put() 62 WfTryJob.Create(master_name, builder_name, build_number).put()
63 63
64 try_job_pipeline = ScheduleCompileTryJobPipeline() 64 try_job_pipeline = ScheduleCompileTryJobPipeline()
65 try_job_id = try_job_pipeline.run( 65 try_job_id = try_job_pipeline.run(
66 master_name, builder_name, build_number, good_revision, bad_revision, 66 master_name, builder_name, build_number, good_revision, bad_revision,
67 failure_type.COMPILE, None, ['r5']) 67 failure_type.COMPILE, None, ['r5'])
68 68
69 try_job = WfTryJob.Get(master_name, builder_name, build_number) 69 try_job = WfTryJob.Get(master_name, builder_name, build_number)
70 try_job_data = WfTryJobData.Get(build_id) 70 try_job_data = WfTryJobData.Get(build_id)
71 71
72 expected_try_job_id = '1' 72 expected_try_job_id = '1'
73 self.assertEqual(expected_try_job_id, try_job_id) 73 self.assertEqual(expected_try_job_id, try_job_id)
74 self.assertEqual( 74 self.assertEqual(
75 expected_try_job_id, try_job.compile_results[-1]['try_job_id']) 75 expected_try_job_id, try_job.compile_results[-1]['try_job_id'])
76 self.assertTrue(expected_try_job_id in try_job.try_job_ids) 76 self.assertTrue(expected_try_job_id in try_job.try_job_ids)
77 self.assertIsNotNone(try_job_data) 77 self.assertIsNotNone(try_job_data)
78 self.assertEqual(try_job_data.master_name, master_name) 78 self.assertEqual(try_job_data.master_name, master_name)
79 self.assertEqual(try_job_data.builder_name, builder_name) 79 self.assertEqual(try_job_data.builder_name, builder_name)
80 self.assertEqual(try_job_data.build_number, build_number) 80 self.assertEqual(try_job_data.build_number, build_number)
81 self.assertEqual( 81 self.assertEqual(
82 try_job_data.try_job_type, 82 try_job_data.try_job_type,
83 failure_type.GetDescriptionForFailureType(failure_type.COMPILE)) 83 failure_type.GetDescriptionForFailureType(failure_type.COMPILE))
84 self.assertFalse(try_job_data.has_compile_targets) 84 self.assertFalse(try_job_data.has_compile_targets)
85 self.assertTrue(try_job_data.has_heuristic_results) 85 self.assertTrue(try_job_data.has_heuristic_results)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698