Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Side by Side Diff: appengine/findit/waterfall/test/schedule_test_try_job_pipeline_test.py

Issue 2203643002: [Findit] Use new mock for unittests. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@0708-pipeline-refactor
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import mock 5 import mock
6 6
7 from common.waterfall import buildbucket_client 7 from common.waterfall import buildbucket_client
8 from common.waterfall import failure_type 8 from common.waterfall import failure_type
9 from model.wf_try_job import WfTryJob 9 from model.wf_try_job import WfTryJob
10 from model.wf_try_job_data import WfTryJobData 10 from model.wf_try_job_data import WfTryJobData
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 '/%s/builds/%s') % ( 44 '/%s/builds/%s') % (
45 master_name, builder_name, build_number) 45 master_name, builder_name, build_number)
46 } 46 }
47 try_job_pipeline = ScheduleTestTryJobPipeline() 47 try_job_pipeline = ScheduleTestTryJobPipeline()
48 properties = try_job_pipeline._GetBuildProperties( 48 properties = try_job_pipeline._GetBuildProperties(
49 master_name, builder_name, build_number, 1, 2, failure_type.TEST, None) 49 master_name, builder_name, build_number, 1, 2, failure_type.TEST, None)
50 50
51 self.assertEqual(properties, expected_properties) 51 self.assertEqual(properties, expected_properties)
52 52
53 @mock.patch.object(schedule_try_job_pipeline, 'buildbucket_client') 53 @mock.patch.object(schedule_try_job_pipeline, 'buildbucket_client')
54 def testSuccessfullyScheduleNewTryJobForTest(self, mock_other): 54 def testSuccessfullyScheduleNewTryJobForTest(self, mock_module):
55 master_name = 'm' 55 master_name = 'm'
56 builder_name = 'b' 56 builder_name = 'b'
57 build_number = 223 57 build_number = 223
58 good_revision = 'rev1' 58 good_revision = 'rev1'
59 bad_revision = 'rev2' 59 bad_revision = 'rev2'
60 targeted_tests = ['a on platform', ['a', ['test1', 'test2']]] 60 targeted_tests = ['a on platform', ['a', ['test1', 'test2']]]
61 build_id = '1' 61 build_id = '1'
62 62
63 response = { 63 response = {
64 'build': { 64 'build': {
65 'id': build_id, 65 'id': build_id,
66 'url': 'url', 66 'url': 'url',
67 'status': 'SCHEDULED', 67 'status': 'SCHEDULED',
68 } 68 }
69 } 69 }
70 results = [(None, buildbucket_client.BuildbucketBuild(response['build']))] 70 results = [(None, buildbucket_client.BuildbucketBuild(response['build']))]
71 mock_other.TriggerTryJobs.return_value = results 71 mock_module.TriggerTryJobs.return_value = results
72 72
73 WfTryJob.Create(master_name, builder_name, build_number).put() 73 WfTryJob.Create(master_name, builder_name, build_number).put()
74 74
75 try_job_pipeline = ScheduleTestTryJobPipeline() 75 try_job_pipeline = ScheduleTestTryJobPipeline()
76 try_job_id = try_job_pipeline.run( 76 try_job_id = try_job_pipeline.run(
77 master_name, builder_name, build_number, good_revision, bad_revision, 77 master_name, builder_name, build_number, good_revision, bad_revision,
78 failure_type.TEST, None, targeted_tests) 78 failure_type.TEST, None, targeted_tests)
79 79
80 try_job = WfTryJob.Get(master_name, builder_name, build_number) 80 try_job = WfTryJob.Get(master_name, builder_name, build_number)
81 self.assertEqual(try_job_id, build_id) 81 self.assertEqual(try_job_id, build_id)
82 self.assertEqual(try_job.test_results[-1]['try_job_id'], build_id) 82 self.assertEqual(try_job.test_results[-1]['try_job_id'], build_id)
83 83
84 try_job_data = WfTryJobData.Get(try_job_id) 84 try_job_data = WfTryJobData.Get(try_job_id)
85 self.assertIsNotNone(try_job_data) 85 self.assertIsNotNone(try_job_data)
86 self.assertEqual(try_job_data.master_name, master_name) 86 self.assertEqual(try_job_data.master_name, master_name)
87 self.assertEqual(try_job_data.builder_name, builder_name) 87 self.assertEqual(try_job_data.builder_name, builder_name)
88 self.assertEqual(try_job_data.build_number, build_number) 88 self.assertEqual(try_job_data.build_number, build_number)
89 self.assertEqual( 89 self.assertEqual(
90 try_job_data.try_job_type, 90 try_job_data.try_job_type,
91 failure_type.GetDescriptionForFailureType(failure_type.TEST)) 91 failure_type.GetDescriptionForFailureType(failure_type.TEST))
92 self.assertFalse(try_job_data.has_compile_targets) 92 self.assertFalse(try_job_data.has_compile_targets)
93 self.assertFalse(try_job_data.has_heuristic_results) 93 self.assertFalse(try_job_data.has_heuristic_results)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698