Move ThreadableLoader to Oilpan heap (1/3)

Move ThreadableLoader to Oilpan heap (1/3)

As a preparation to the oilpanization, this CL forbids holding a
FileReaderLoader instance directly. Instead, use
std::unique_ptr<FileReaderLoader>.

BUG=587663
Committed: https://crrev.com/b6e40e387dd63294292f8b7a831abb77e886fcab
Cr-Commit-Position: refs/heads/master@{#409729}

[yhirano, 2016-07-29 09:59:18]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 09:59:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-07-29 10:09:38]

Description was changed from

==========
Move ThreadableLoader to Oilpan heap (1/3)

As a preparation to the oilpanization, this CL forbids holding a
FileReaderLoader instance directly. Instead, use
std::unique_ptr<FileReaderLoader>.

BUG=587663
==========

to

==========
Move ThreadableLoader to Oilpan heap (1/3)

As a preparation to the oilpanization, this CL forbids holding a
FileReaderLoader instance directly. Instead, use
std::unique_ptr<FileReaderLoader>.

BUG=587663
==========

[yhirano, 2016-07-29 10:09:38]

yhirano@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-07-29 10:17:29]

LGTM. Thanks for splitting!

[commit-bot: I haz the power, 2016-07-29 11:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 11:08:10]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-08-01 05:51:54]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 05:52:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 07:02:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 07:02:38]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-08-04 03:07:29]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 03:07:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 05:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 05:08:47]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhirano, 2016-08-04 06:06:53]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 06:07:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-08-04 06:31:44]

The CQ bit was unchecked by yhirano@chromium.org

[yhirano, 2016-08-04 06:31:53]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-08-04 06:31:53]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2193173002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-04 06:32:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 06:38:04]

Description was changed from

==========
Move ThreadableLoader to Oilpan heap (1/3)

As a preparation to the oilpanization, this CL forbids holding a
FileReaderLoader instance directly. Instead, use
std::unique_ptr<FileReaderLoader>.

BUG=587663
==========

to

==========
Move ThreadableLoader to Oilpan heap (1/3)

As a preparation to the oilpanization, this CL forbids holding a
FileReaderLoader instance directly. Instead, use
std::unique_ptr<FileReaderLoader>.

BUG=587663
==========

[commit-bot: I haz the power, 2016-08-04 06:38:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-04 06:39:47]

Description was changed from

==========
Move ThreadableLoader to Oilpan heap (1/3)

As a preparation to the oilpanization, this CL forbids holding a
FileReaderLoader instance directly. Instead, use
std::unique_ptr<FileReaderLoader>.

BUG=587663
==========

to

==========
Move ThreadableLoader to Oilpan heap (1/3)

As a preparation to the oilpanization, this CL forbids holding a
FileReaderLoader instance directly. Instead, use
std::unique_ptr<FileReaderLoader>.

BUG=587663

Committed: https://crrev.com/b6e40e387dd63294292f8b7a831abb77e886fcab
Cr-Commit-Position: refs/heads/master@{#409729}
==========

[commit-bot: I haz the power, 2016-08-04 06:39:48]

Patchset 2 (id:??) landed as
https://crrev.com/b6e40e387dd63294292f8b7a831abb77e886fcab
Cr-Commit-Position: refs/heads/master@{#409729}