third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h - Issue 2193173002: Move ThreadableLoader to Oilpan heap (1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h

Issue 2193173002: Move ThreadableLoader to Oilpan heap (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp ('k') | third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h

diff --git a/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h b/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h

index de3f72ad4d323e785776e487e9a05e48cf4936d5..119e3dff83256062743011e0cadb7f7ea59aaf7d 100644

--- a/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h

+++ b/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h

@@ -40,6 +40,7 @@

#include "core/imagebitmap/ImageBitmapOptions.h"

#include "platform/Supplementable.h"

#include "platform/geometry/IntRect.h"

+#include <memory>

class SkImage;

@@ -101,7 +102,7 @@ private:

void didFinishLoading() override;

void didFail(FileError::ErrorCode) override;

- FileReaderLoader m_loader;

+ std::unique_ptr<FileReaderLoader> m_loader;

Member<ImageBitmapFactories> m_factory;

Member<ScriptPromiseResolver> m_resolver;

Optional<IntRect> m_cropRect;