third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp - Issue 2193173002: Move ThreadableLoader to Oilpan heap (1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 2193173002: Move ThreadableLoader to Oilpan heap (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('k') | third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

index c1ccce2b58ba49d0a97749041e2c272a8ee73015..7540e00738ac65d18a46e834660d62362e0c6b49 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

@@ -123,9 +123,9 @@ class PresentationConnection::BlobLoader final : public GarbageCollectedFinalize

public:

BlobLoader(PassRefPtr<BlobDataHandle> blobDataHandle, PresentationConnection* PresentationConnection)

: m_PresentationConnection(PresentationConnection)

- , m_loader(FileReaderLoader::ReadAsArrayBuffer, this)

+ , m_loader(FileReaderLoader::create(FileReaderLoader::ReadAsArrayBuffer, this))

{

- m_loader.start(m_PresentationConnection->getExecutionContext(), blobDataHandle);

+ m_loader->start(m_PresentationConnection->getExecutionContext(), blobDataHandle);

}

~BlobLoader() override { }

@@ -134,7 +134,7 @@ public:

void didReceiveData() override { }

void didFinishLoading() override

{

- m_PresentationConnection->didFinishLoadingBlob(m_loader.arrayBufferResult());

+ m_PresentationConnection->didFinishLoadingBlob(m_loader->arrayBufferResult());

}

void didFail(FileError::ErrorCode errorCode) override

{

@@ -143,7 +143,7 @@ public:

void cancel()

{

- m_loader.cancel();

+ m_loader->cancel();

}

DEFINE_INLINE_TRACE()

@@ -153,7 +153,7 @@ public:

private:

Member<PresentationConnection> m_PresentationConnection;

- FileReaderLoader m_loader;

+ std::unique_ptr<FileReaderLoader> m_loader;

};

PresentationConnection::PresentationConnection(LocalFrame* frame, const String& id, const String& url)