Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

Issue 2193173002: Move ThreadableLoader to Oilpan heap (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
diff --git a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
index 456d2711ef7e3e8c6e4793dcb4dc1c449dc87872..d2d916ca0080039658533c4e7078a5393323a2b1 100644
--- a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
+++ b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
@@ -80,7 +80,7 @@ public:
private:
Member<DocumentWebSocketChannel> m_channel;
- FileReaderLoader m_loader;
+ std::unique_ptr<FileReaderLoader> m_loader;
};
class DocumentWebSocketChannel::Message : public GarbageCollectedFinalized<DocumentWebSocketChannel::Message> {
@@ -110,21 +110,21 @@ public:
DocumentWebSocketChannel::BlobLoader::BlobLoader(PassRefPtr<BlobDataHandle> blobDataHandle, DocumentWebSocketChannel* channel)
: m_channel(channel)
- , m_loader(FileReaderLoader::ReadAsArrayBuffer, this)
+ , m_loader(FileReaderLoader::create(FileReaderLoader::ReadAsArrayBuffer, this))
{
- m_loader.start(channel->getExecutionContext(), blobDataHandle);
+ m_loader->start(channel->getExecutionContext(), blobDataHandle);
}
void DocumentWebSocketChannel::BlobLoader::cancel()
{
- m_loader.cancel();
+ m_loader->cancel();
// didFail will be called immediately.
// |this| is deleted here.
}
void DocumentWebSocketChannel::BlobLoader::didFinishLoading()
{
- m_channel->didFinishLoadingBlob(m_loader.arrayBufferResult());
+ m_channel->didFinishLoadingBlob(m_loader->arrayBufferResult());
// |this| is deleted here.
}
« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698