third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp - Issue 2193173002: Move ThreadableLoader to Oilpan heap (1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 2193173002: Move ThreadableLoader to Oilpan heap (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

index 5868ce54d5fb9504d4323418ecb31fd22e00c991..f84736aba6d9cfef720a23103388cd5ccb9abdce 100644

--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

@@ -165,7 +165,7 @@ public:

void cancel()

{

- m_loader.cancel();

+ m_loader->cancel();

}

DEFINE_INLINE_TRACE()

@@ -176,13 +176,13 @@ public:

private:

BlobLoader(XMLHttpRequest* xhr, PassRefPtr<BlobDataHandle> handle)

: m_xhr(xhr)

- , m_loader(FileReaderLoader::ReadByClient, this)

+ , m_loader(FileReaderLoader::create(FileReaderLoader::ReadByClient, this))

{

- m_loader.start(m_xhr->getExecutionContext(), handle);

+ m_loader->start(m_xhr->getExecutionContext(), handle);

}

Member<XMLHttpRequest> m_xhr;

- FileReaderLoader m_loader;

+ std::unique_ptr<FileReaderLoader> m_loader;

};

XMLHttpRequest* XMLHttpRequest::create(ScriptState* scriptState)