third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp - Issue 2193173002: Move ThreadableLoader to Oilpan heap (1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

Issue 2193173002: Move ThreadableLoader to Oilpan heap (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onheap-bridge-peer-in-worker-threadable-loader

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h ('k') | third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

diff --git a/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp b/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

index 3e592171724a65243535f813345cc0d8123db473..9087a88da848ed07f14e72f4fdf25a906ecb17b7 100644

--- a/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

+++ b/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp

@@ -167,7 +167,7 @@ void ImageBitmapFactories::didFinishLoading(ImageBitmapLoader* loader)

}

ImageBitmapFactories::ImageBitmapLoader::ImageBitmapLoader(ImageBitmapFactories& factory, Optional<IntRect> cropRect, ScriptState* scriptState, const ImageBitmapOptions& options)

- : m_loader(FileReaderLoader::ReadAsArrayBuffer, this)

+ : m_loader(FileReaderLoader::create(FileReaderLoader::ReadAsArrayBuffer, this))

, m_factory(&factory)

, m_resolver(ScriptPromiseResolver::create(scriptState))

, m_cropRect(cropRect)

@@ -177,7 +177,7 @@ ImageBitmapFactories::ImageBitmapLoader::ImageBitmapLoader(ImageBitmapFactories&

void ImageBitmapFactories::ImageBitmapLoader::loadBlobAsync(ExecutionContext* context, Blob* blob)

{

- m_loader.start(context, blob->blobDataHandle());

+ m_loader->start(context, blob->blobDataHandle());

}

DEFINE_TRACE(ImageBitmapFactories)

@@ -195,7 +195,7 @@ void ImageBitmapFactories::ImageBitmapLoader::rejectPromise()

void ImageBitmapFactories::ImageBitmapLoader::didFinishLoading()

{

- DOMArrayBuffer* arrayBuffer = m_loader.arrayBufferResult();

+ DOMArrayBuffer* arrayBuffer = m_loader->arrayBufferResult();

if (!arrayBuffer) {

rejectPromise();

return;