Disable broken iOS10 password manager tests.

Disable broken iOS10 password manager tests.

Some keychain access is currently broken on the latest Xcode beta.

BUG=619982
Committed: https://crrev.com/4c702c39d959fc972e9226c008a19cd8b3df4fce
Cr-Commit-Position: refs/heads/master@{#407486}

[justincohen, 2016-07-24 01:38:20]

justincohen@chromium.org changed reviewers:
+ rohitrao@chromium.org

[justincohen, 2016-07-24 01:38:20]

ptal

[justincohen, 2016-07-24 01:38:28]

The CQ bit was checked by justincohen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-24 01:38:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-24 02:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-24 02:14:03]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2016-07-24 23:04:55]

sdefresne@ or vabr@ will need to sign off on this as OWNERS.

https://codereview.chromium.org/2180773002/diff/20001/components/password_man...
File components/password_manager/core/browser/login_database_unittest.cc
(right):

https://codereview.chromium.org/2180773002/diff/20001/components/password_man...
components/password_manager/core/browser/login_database_unittest.cc:15: #include
"base/ios/ios_util.h"
This is a cross-platform test, so this include will need to be behind OS_IOS. 
We'll also need to conditionally disable the test based on OS version.

https://codereview.chromium.org/2180773002/diff/20001/components/password_man...
components/password_manager/core/browser/login_database_unittest.cc:215: //
TODO(crbug.com/619982): Broken by iOS10.
I would be more specific in this comment and say that we believe this is broken
because of a bug in the iOS 10 simulator (that we expect to be fixed?).

[rohitrao (ping after 24h), 2016-07-24 23:05:18]

Description was changed from

==========
Disable broken iOS10 tests.

Some keychain access is currently broken on the latest Xcode beta.

BUG=619982
==========

to

==========
Disable broken iOS10 password manager tests.

Some keychain access is currently broken on the latest Xcode beta.

BUG=619982
==========

[vabr (Chromium), 2016-07-25 07:38:53]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2016-07-25 07:38:54]

Thanks, this LGTM, given Rohit's comments are addressed.

Is it known what is the issue with iOS 10? Is there something I should
investigate on the password manager side? If we find that the tests are broken
(as opposed to broken SDK or production code), we should file a bug for them and
make it block http://crbug.com/355145.

Also, we plan to switch to using the plain POSIX implementation of LoginDatabase
on iOS soon (http://crbug.com/520437). Would speeding that migration up help
with the iOS-related issues?

Cheers,
Vaclav

[justincohen, 2016-07-25 15:11:52]

The bug appears to be in the simulator's Keychain Services implementation. 
SecItem* always fails with -34018.  There are very ugly workaround options, but
we expect this to be fixed fairly quickly.

https://codereview.chromium.org/2180773002/diff/20001/components/password_man...
File components/password_manager/core/browser/login_database_unittest.cc
(right):

https://codereview.chromium.org/2180773002/diff/20001/components/password_man...
components/password_manager/core/browser/login_database_unittest.cc:15: #include
"base/ios/ios_util.h"
On 2016/07/24 23:04:55, rohitrao wrote:
> This is a cross-platform test, so this include will need to be behind OS_IOS. 
> We'll also need to conditionally disable the test based on OS version.

Done.

https://codereview.chromium.org/2180773002/diff/20001/components/password_man...
components/password_manager/core/browser/login_database_unittest.cc:215: //
TODO(crbug.com/619982): Broken by iOS10.
On 2016/07/24 23:04:55, rohitrao wrote:
> I would be more specific in this comment and say that we believe this is
broken
> because of a bug in the iOS 10 simulator (that we expect to be fixed?).

Done.

[justincohen, 2016-07-25 15:14:01]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-07-25 15:14:01]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2180773002/#ps60001
(title: "format")

[commit-bot: I haz the power, 2016-07-25 15:14:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 15:47:54]

Description was changed from

==========
Disable broken iOS10 password manager tests.

Some keychain access is currently broken on the latest Xcode beta.

BUG=619982
==========

to

==========
Disable broken iOS10 password manager tests.

Some keychain access is currently broken on the latest Xcode beta.

BUG=619982
==========

[commit-bot: I haz the power, 2016-07-25 15:47:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-25 15:49:12]

Description was changed from

==========
Disable broken iOS10 password manager tests.

Some keychain access is currently broken on the latest Xcode beta.

BUG=619982
==========

to

==========
Disable broken iOS10 password manager tests.

Some keychain access is currently broken on the latest Xcode beta.

BUG=619982

Committed: https://crrev.com/4c702c39d959fc972e9226c008a19cd8b3df4fce
Cr-Commit-Position: refs/heads/master@{#407486}
==========

[commit-bot: I haz the power, 2016-07-25 15:49:14]

Patchset 4 (id:??) landed as
https://crrev.com/4c702c39d959fc972e9226c008a19cd8b3df4fce
Cr-Commit-Position: refs/heads/master@{#407486}

[justincohen, 2016-08-02 18:34:08]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2202403002/ by justincohen@chromium.org.

The reason for reverting is: Fixed by
https://codereview.chromium.org/2187343003/.