Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2202403002: Revert of Disable broken iOS10 password manager tests. (Closed)

Created:
4 years, 4 months ago by justincohen
Modified:
4 years, 4 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable broken iOS10 password manager tests. (patchset #4 id:60001 of https://codereview.chromium.org/2180773002/ ) Reason for revert: Fixed by https://codereview.chromium.org/2187343003/ Original issue's description: > Disable broken iOS10 password manager tests. > > Some keychain access is currently broken on the latest Xcode beta. > > BUG=619982 > > Committed: https://crrev.com/4c702c39d959fc972e9226c008a19cd8b3df4fce > Cr-Commit-Position: refs/heads/master@{#407486} TBR=rohitrao@chromium.org,vabr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=619982 TBR=vabr Committed: https://crrev.com/30154d561457589c98fb9491737084852e73b3fa Cr-Commit-Position: refs/heads/master@{#409274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M components/password_manager/core/browser/login_database_ios_unittest.cc View 4 chunks +0 lines, -28 lines 0 comments Download
M components/password_manager/core/browser/login_database_unittest.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
justincohen
Created Revert of Disable broken iOS10 password manager tests.
4 years, 4 months ago (2016-08-02 18:34:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202403002/1
4 years, 4 months ago (2016-08-02 18:35:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 19:36:03 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 19:37:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30154d561457589c98fb9491737084852e73b3fa
Cr-Commit-Position: refs/heads/master@{#409274}

Powered by Google App Engine
This is Rietveld 408576698